[branch-53] feat: parse JsonAccess as a binary operator, add Operator::Colon#20717
Merged
alamb merged 1 commit intoapache:branch-53from Mar 5, 2026
Merged
[branch-53] feat: parse JsonAccess as a binary operator, add Operator::Colon#20717alamb merged 1 commit intoapache:branch-53from
JsonAccess as a binary operator, add Operator::Colon#20717alamb merged 1 commit intoapache:branch-53from
Conversation
…tor::Colon` (apache#20628) Backport of apache#20628 on v53 branch. - Convert `JsonAccess` from sqlparser as a normal binary operator - Add `Operator::Colon` - Needed for datafusion-contrib/datafusion-variant#26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
53.0.0(Feb 2026 / Mar 2026) #19692Needed in colon
:operator - initial implementation datafusion-contrib/datafusion-variant#26Backport of feat: parse
JsonAccessas a binary operator, addOperator::Colon#20628 on v53 branch.Rationale for this change
sqlparser-rscurrently exposes the colon operator (:) as a specialJsonAccessexpression. So it fails in datafusion's parsing before anExprPlanneris even invoked.Operator::Colon. Currently it's not used/implemented in datafusion.What changes are included in this PR?
JsonAccessto a normal binary expr, on which theExprPlanneris invoked and custom parsing can be done.Are these changes tested?
Added tests.
Also did a prototype of a custom
ExprPlannerin datafusion-variant using this to convert colon operator tovariant_getfunction - datafusion-contrib/datafusion-variant#31Are there any user-facing changes?
Add
Operator::Colon