[DSIP-82][Master/Worker] Use FAILOVER_FINISH_NODES to avoid duplicate workflow/task when failover #16821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
EricGao888,
Gallardot,
SbloodyS and
caishunfeng
as code owners
ruanwenjun
changed the title
ruanwenjun
force-pushed
the
dev_wenjun_removeWaittingStrategy
branch
from
9a195bd to
978665e
Compare
ruanwenjun
force-pushed
the
dev_wenjun_removeWaittingStrategy
branch
from
978665e to
91638d0
Compare
SbloodyS
previously approved these changes
Nov 20, 2024
ruanwenjun
force-pushed
the
dev_wenjun_removeWaittingStrategy
branch
3 times, most recently
from
bdc06d8 to
b6e52fc
Compare
ruanwenjun
changed the title
ruanwenjun
force-pushed
the
dev_wenjun_removeWaittingStrategy
branch
from
b6e52fc to
3a61665
Compare
SbloodyS
previously approved these changes
Nov 20, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...uler-registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/RegistryClient.java
Fixed
Show fixed
Hide fixed
ruanwenjun
dismissed stale reviews from SbloodyS and caishunfeng
via
6cb0713
ruanwenjun
force-pushed
the
dev_wenjun_removeWaittingStrategy
branch
from
3a61665 to
6cb0713
Compare
...uler-registry-api/src/main/java/org/apache/dolphinscheduler/registry/api/RegistryClient.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_removeWaittingStrategy
branch
from
6cb0713 to
e7e788f
Compare
… workflow/task when failover
ruanwenjun
force-pushed
the
dev_wenjun_removeWaittingStrategy
branch
from
e7e788f to
60ae3fb
Compare
|
SbloodyS
approved these changes
Nov 20, 2024
caishunfeng
approved these changes
Nov 20, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull reques
related issue #16759
close #16825
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md