Skip to content

Conversation

@zhu3pang
Copy link
Contributor

Purpose of the pull request

fix #16758
This pull request will create a Fatal Error Log when the server crash.

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 21, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@SbloodyS SbloodyS added first time contributor First-time contributor improvement make more easy to user or prompt friendly labels Nov 21, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Nov 21, 2024
@sonarqubecloud
Copy link

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gallardot Gallardot merged commit b885970 into apache:dev Nov 21, 2024
68 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 21, 2024

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend first time contributor First-time contributor improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Deploy] Record the fatal error Log

4 participants