Skip to content

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Nov 22, 2024

Purpose of the pull request

close #16835

Brief change log

  • Remove projectcode, workflow instance/xx in task instance working directory path

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added this to the 3.3.0 milestone Nov 22, 2024
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Nov 22, 2024
SbloodyS
SbloodyS previously approved these changes Nov 22, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixTaskWorkingDirIsNotDelete branch from ec43484 to 5ce3f8c Compare November 25, 2024 12:25
@sonarqubecloud
Copy link

Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS merged commit 20e9ffa into apache:dev Nov 26, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.0 backend improvement make more easy to user or prompt friendly test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Worker] Clear empty directory under task working path after task instance finish

3 participants