[Fix-16903] Fix monitor page cannot display well#16968
Merged
SbloodyS merged 1 commit intoapache:devfrom Jan 24, 2025
Merged
Conversation
ruanwenjun
requested review from
EricGao888,
Gallardot,
SbloodyS,
caishunfeng and
songjianet
as code owners
SbloodyS
reviewed
Jan 22, 2025
Member
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
Frontend build failed. @ruanwenjun
ruanwenjun
force-pushed
the
dev_wenjun_fixMonitor
branch
2 times, most recently
from
b33e941 to
02f0164
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixMonitor
branch
2 times, most recently
from
39e4b5c to
4afbcd4
Compare
SbloodyS
reviewed
Jan 22, 2025
...r-registry-jdbc/src/main/java/org/apache/dolphinscheduler/plugin/registry/jdbc/KeyUtils.java
Outdated
Show resolved
Hide resolved
...r-registry-jdbc/src/main/java/org/apache/dolphinscheduler/plugin/registry/jdbc/KeyUtils.java
Outdated
Show resolved
Hide resolved
ruanwenjun
force-pushed
the
dev_wenjun_fixMonitor
branch
from
4afbcd4 to
bdd3ee4
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixMonitor
branch
from
bdd3ee4 to
f77a616
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
zhongjiajie
approved these changes
Jan 23, 2025
| .systemMemoryUsedPercentage((double) (totalSystemMemory - systemMemoryAvailable) / totalSystemMemory) | ||
| .diskUsed(diskToTalBytes - diskFreeBytes) | ||
| .diskTotal(diskToTalBytes) | ||
| .diskUsedPercentage((diskToTalBytes - diskFreeBytes) / diskToTalBytes) |
Member
There was a problem hiding this comment.
nothing but want to make sure we store as float in stock and render as '\d %' right?
Member
Author
There was a problem hiding this comment.
We will render as string by
<Gauge
data={(
JSON.parse(item.heartBeatInfo).diskUsage * 100
).toFixed(2)}
/>
It works well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16903
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md