Skip to content

[Improvement-17288] CodeGenerateException is swallowed in ProcessDefinitionDemo#17289

Merged
SbloodyS merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_removeCache
Jun 28, 2025
Merged

[Improvement-17288] CodeGenerateException is swallowed in ProcessDefinitionDemo#17289
SbloodyS merged 1 commit intoapache:devfrom
ruanwenjun:dev_wenjun_removeCache

Conversation

@ruanwenjun
Copy link
Member

Purpose of the pull request

close #17288

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun ruanwenjun self-assigned this Jun 26, 2025
@ruanwenjun ruanwenjun added bug Something isn't working and removed backend test labels Jun 26, 2025
@ruanwenjun ruanwenjun added this to the 3.3.1 milestone Jun 26, 2025
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Jun 26, 2025
@ruanwenjun ruanwenjun changed the title [Fix-17288] CodeGenerateException is swallowed in ProcessDefinitionDemo [Improvement-17288] CodeGenerateException is swallowed in ProcessDefinitionDemo Jun 26, 2025
@ruanwenjun ruanwenjun removed the bug Something isn't working label Jun 26, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.8% Coverage on New Code (required ≥ 60%)
47.9% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

@SbloodyS SbloodyS merged commit ce7440d into apache:dev Jun 28, 2025
96 of 107 checks passed
eco8848 pushed a commit to eco8848/dolphinscheduler that referenced this pull request Aug 8, 2025
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend improvement make more easy to user or prompt friendly test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] CodeGenerateException is swallowed in ProcessDefinitionDemo

3 participants