[Fix-17704][HttpTask] The output parameters of an HTTP task cannot be referenced in downstream tasks.#17716
[Fix-17704][HttpTask] The output parameters of an HTTP task cannot be referenced in downstream tasks.#17716Gallardot merged 27 commits intoapache:devfrom
Conversation
…istorical versions in the workflow does not invoke lineage deletion. Therefore, logic for deleting lineages should be added when deleting workflows.
…cal library data.
…istorical versions in the workflow does not invoke lineage deletion. Therefore, logic for deleting lineages should be added when deleting workflows.
…cal library data.
det101
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #17637 where HTTP task output parameters could not be referenced in downstream tasks. The fix ensures that the variable pool containing output parameters is properly propagated to the TaskExecutionContext by calling setVarPool() after request validation.
- Adds
taskExecutionContext.setVarPool()call in thehandle()method to propagate output parameters - Adds comprehensive test coverage to verify varPool is correctly set on the TaskExecutionContext
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| HttpTask.java | Adds call to taskExecutionContext.setVarPool() to propagate HTTP response output parameters to downstream tasks |
| HttpTaskTest.java | Adds test case to verify that varPool is correctly set on TaskExecutionContext after HTTP request execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
...scheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpTask.java
Show resolved
Hide resolved
…in/java/org/apache/dolphinscheduler/plugin/task/http/HttpTask.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
det101
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The testCreateDolphinDBDataSource e2e error should be related to this commit. Please help me re-trigger it @SbloodyS |
|
Purpose of the pull request
close #17704
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md