-
Notifications
You must be signed in to change notification settings - Fork 5k
[Improvement-17248][UI] Optimize file details display area to reduce blank space #17731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
15fd520
[Improvement-17248][UI] Optimize file details display area to reduce …
zhan7236 6b4ef87
refactor: address Copilot AI code review feedback
zhan7236 13513de
Merge branch 'dev' into Improvement-17248
SbloodyS 1911642
style: fix trailing whitespace in create/index.tsx
zhan7236 acb222b
refactor: use Flexbox layout to optimize file editor display area
zhan7236 22c8e59
fix: add overflow hidden to prevent editor from infinite expansion
zhan7236 9bfbe36
Merge branch 'dev' into Improvement-17248
SbloodyS 148fa5c
fix: use viewport-based height calculation for Monaco Editor to ensur…
zhan7236 1047a44
Merge branch 'dev' into Improvement-17248
SbloodyS e36757d
Merge branch 'dev' into Improvement-17248
zhan7236 abecfd8
Merge branch 'dev' into Improvement-17248
SbloodyS 761ef2d
fix: run pnpm lint to fix code format
zhan7236 1c8ddf8
Merge branch 'dev' into Improvement-17248
SbloodyS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
dolphinscheduler-ui/src/views/resource/components/resource/constants.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** | ||
| * Monaco Editor vertical offset for file edit page | ||
| * This offset accounts for: | ||
| * - Page header and navigation (~80px) | ||
| * - Card title and padding (~60px) | ||
| * - File name display (~60px) | ||
| * - Form padding and button area (~120px) | ||
| * Total: ~320px | ||
| */ | ||
| export const EDITOR_VERTICAL_OFFSET_EDIT = 320 | ||
|
|
||
| /** | ||
| * Monaco Editor vertical offset for file create page | ||
| * This offset accounts for: | ||
| * - Page header and navigation (~80px) | ||
| * - Card title and padding (~60px) | ||
| * - File name input field (~80px) | ||
| * - File format selector (~80px) | ||
| * - Form padding and button area (~120px) | ||
| * Total: ~420px | ||
| */ | ||
| export const EDITOR_VERTICAL_OFFSET_CREATE = 420 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.