Skip to content

[DSIP-94][PyTorch] Remove pytorch task type#17808

Merged
SbloodyS merged 5 commits intoapache:devfrom
SbloodyS:dsip_94
Dec 22, 2025
Merged

[DSIP-94][PyTorch] Remove pytorch task type#17808
SbloodyS merged 5 commits intoapache:devfrom
SbloodyS:dsip_94

Conversation

@SbloodyS
Copy link
Member

Purpose of the pull request

close #17720

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@SbloodyS SbloodyS added this to the 3.4.0 milestone Dec 19, 2025
@SbloodyS SbloodyS self-assigned this Dec 19, 2025
@SbloodyS SbloodyS requested a review from EricGao888 as a code owner December 19, 2025 02:44
@SbloodyS SbloodyS added UI ui and front end related backend DSIP labels Dec 19, 2025
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to delete the plugin item at t_ds_plugin_define.
And I am not clear if the ui will error if db exist pytorch task definition.

@SbloodyS
Copy link
Member Author

We may need to delete the plugin item at t_ds_plugin_define. And I am not clear if the ui will error if db exist pytorch task definition.

  1. t_ds_plugin_define will not affect the user's use, and we may not have to delete it.
  2. Since we have marked this as an incompatible update, we can tell the user to manually delete the related task data in the document. Is this ok?

Gallardot
Gallardot previously approved these changes Dec 19, 2025
@ruanwenjun
Copy link
Member

We may need to delete the plugin item at t_ds_plugin_define. And I am not clear if the ui will error if db exist pytorch task definition.

  1. t_ds_plugin_define will not affect the user's use, and we may not have to delete it.
  2. Since we have marked this as an incompatible update, we can tell the user to manually delete the related task data in the document. Is this ok?

It's ok to explain this in the document and don't modify the data in db.

@SbloodyS SbloodyS requested a review from ruanwenjun December 22, 2025 02:39
@SbloodyS
Copy link
Member Author

It's ok to explain this in the document and don't modify the data in db.

Done. PTAL. @ruanwenjun

zhongjiajie
zhongjiajie previously approved these changes Dec 22, 2025
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

@SbloodyS SbloodyS merged commit a32040e into apache:dev Dec 22, 2025
74 of 76 checks passed
@SbloodyS SbloodyS deleted the dsip_94 branch December 22, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DSIP-94][PyTorch] Suggest remove pytorch task type

4 participants