Skip to content

[Fix-17848] Fix incorrect placement of JVM arguments in java task #17850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SbloodyS merged 2 commits into from
Jan 6, 2026
+6 −6
Merged

[Fix-17848] Fix incorrect placement of JVM arguments in java task #17850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71c6298
[Fix-17848] Fix incorrect placement of JVM arguments in java task
Mrhs121 Jan 5, 2026
f5a98a9
Merge branch 'dev' into Fix-17848
Gallardot Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...eduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,11 @@ protected String buildJarCommand() {
StringBuilder builder = new StringBuilder();
builder.append(getJavaCommandPath())
.append("java").append(Constants.SPACE)
.append(javaParameters.getJvmArgs().trim()).append(Constants.SPACE)
.append(buildResourcePath()).append(Constants.SPACE)
.append("-jar").append(Constants.SPACE)
.append(mainJarAbsolutePathInLocal).append(Constants.SPACE)
.append(javaParameters.getMainArgs().trim()).append(Constants.SPACE)
.append(javaParameters.getJvmArgs().trim());
.append(javaParameters.getMainArgs().trim());
return builder.toString();
}

Expand All @@ -165,10 +165,10 @@ protected String buildNormalJarCommand() {
StringBuilder builder = new StringBuilder();
builder.append(getJavaCommandPath())
.append("java").append(Constants.SPACE)
.append(javaParameters.getJvmArgs().trim()).append(Constants.SPACE)
.append(buildResourcePath()).append(Constants.SPACE)
.append(mainJarName).append(Constants.SPACE)
.append(javaParameters.getMainArgs().trim()).append(Constants.SPACE)
.append(javaParameters.getJvmArgs().trim());
.append(javaParameters.getMainArgs().trim());
return builder.toString();
}

Expand Down
4 changes: 2 additions & 2 deletions ...er-task-java/src/test/java/org/apache/dolphinscheduler/plugin/task/java/JavaTaskTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ void buildJarCommand() {
JavaTask javaTask = runJarType();
assertThat(javaTask.buildJarCommand())
.isEqualTo(
"${JAVA_HOME}/bin/java -classpath .:/tmp/dolphinscheduler/test/executepath:/tmp/dolphinscheduler/test/executepath/opt/share/jar/resource2.jar -jar /tmp/dolphinscheduler/test/executepath/opt/share/jar/main.jar -host 127.0.0.1 -port 8080 -xms:50m");
"${JAVA_HOME}/bin/java -xms:50m -classpath .:/tmp/dolphinscheduler/test/executepath:/tmp/dolphinscheduler/test/executepath/opt/share/jar/resource2.jar -jar /tmp/dolphinscheduler/test/executepath/opt/share/jar/main.jar -host 127.0.0.1 -port 8080");
}

/**
Expand All @@ -68,7 +68,7 @@ void buildNormalJarCommand() {
JavaTask javaTask = runNormalJarType();
assertThat(javaTask.buildNormalJarCommand())
.isEqualTo(
"${JAVA_HOME}/bin/java -classpath .:/tmp/dolphinscheduler/test/executepath:/tmp/dolphinscheduler/test/executepath/opt/share/jar/resource2.jar:/tmp/dolphinscheduler/test/executepath/opt/share/jar/main.jar Test -host 127.0.0.1 -port 8080 -xms:50m");
"${JAVA_HOME}/bin/java -xms:50m -classpath .:/tmp/dolphinscheduler/test/executepath:/tmp/dolphinscheduler/test/executepath/opt/share/jar/resource2.jar:/tmp/dolphinscheduler/test/executepath/opt/share/jar/main.jar Test -host 127.0.0.1 -port 8080");
}

/**
Expand Down
Loading