[Improvement-17855] Supports the custom and built-in variables for java task#17860
Merged
ruanwenjun merged 3 commits intoapache:devfrom Jan 8, 2026
Merged
[Improvement-17855] Supports the custom and built-in variables for java task#17860ruanwenjun merged 3 commits intoapache:devfrom
ruanwenjun merged 3 commits intoapache:devfrom
Conversation
Mrhs121
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
Contributor
Author
Done |
|
ruanwenjun
approved these changes
Jan 8, 2026
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
LGTM, please use a more readable method name next time.
| return JAVA_HOME_VAR + File.separator + "bin" + File.separator; | ||
| } | ||
|
|
||
| private String parseParameter(String script) { |
Member
There was a problem hiding this comment.
Suggested change
| private String parseParameter(String script) { | |
| private String assemblyParameterPlaceholders(String script) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17855
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md