[Improvement-17874][ApiServer] Remove the default value of expireTime and let the user choose the time#17907
[Improvement-17874][ApiServer] Remove the default value of expireTime and let the user choose the time#17907njnu-seafish wants to merge 5 commits intoapache:devfrom
Conversation
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
I'm +0 on this. Waiting for other's opinions.
SbloodyS
changed the title
a customer need to create a token to call DS services and report that the token was already expired immediately after creation. |
|
We should set the time to empty here, let user provide a validated value, the system should not provide unreasonable default values. |
|
| : null | ||
| ), | ||
| expireTime: ref(Date.now()), | ||
| expireTime: null as number | Date | null, |
There was a problem hiding this comment.
expireTime should not be number
There was a problem hiding this comment.
expireTime should not be
number
dolphinscheduler-ui/src/views/security/token-manage/components/token-modal.tsx
variables.model.expireTime = new Date(props.row.expireTime).getTime()
3 participants
Purpose of the pull request
close #17874
Brief change log
Remove the default value of expireTime and let the user choose the time
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md