-
Notifications
You must be signed in to change notification settings - Fork 5k
[Feature-17787] Support config max task log size for per task #17935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dill21yu
wants to merge
6
commits into
apache:dev
Choose a base branch
from
dill21yu:task-log-max-size-limit
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d0309b3
[Feature-17787]Support config max task log size for per task
ea1232f
Merge branch 'dev' into task-log-max-size-limit
dill21yu dc208f0
[Feature-17787]Support config max task log size for per task fix CI e…
99b6463
Merge remote-tracking branch 'origin/task-log-max-size-limit' into ta…
ded47e8
Merge branch 'dev' into task-log-max-size-limit
dill21yu 42a3556
Merge branch 'dev' into task-log-max-size-limit
SbloodyS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
167 changes: 167 additions & 0 deletions
167
...scheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/LogUtilsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.dolphinscheduler.common.utils; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| import java.io.File; | ||
| import java.net.URL; | ||
| import java.util.List; | ||
|
|
||
| import org.junit.jupiter.api.AfterEach; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class LogUtilsTest { | ||
|
|
||
| private String predefinedLogPath; | ||
|
|
||
| @BeforeEach | ||
| public void setUp() { | ||
| URL resourceUrl = getClass().getClassLoader().getResource("log/730.log"); | ||
| if (resourceUrl != null) { | ||
| predefinedLogPath = resourceUrl.getPath(); | ||
| } | ||
| } | ||
|
|
||
| @AfterEach | ||
| public void tearDown() { | ||
| } | ||
|
|
||
| @Test | ||
| public void testReadPartFileContentFromLocal_Success() { | ||
| if (predefinedLogPath != null) { | ||
| String path = predefinedLogPath.replace("%20", " "); | ||
| List<String> result = LogUtils.readPartFileContentFromLocal(path, 1, 3); | ||
|
|
||
| assertNotNull(result); | ||
| assertTrue(result.size() >= 0); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testReadPartFileContentFromLocal_SkipNoneLimitAll() { | ||
| if (predefinedLogPath != null) { | ||
| String path = predefinedLogPath.replace("%20", " "); | ||
| List<String> result = LogUtils.readPartFileContentFromLocal(path, 0, 100); | ||
|
|
||
| assertNotNull(result); | ||
| assertTrue(result.size() >= 0); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testReadPartFileContentFromPredefinedRollingFiles() { | ||
| if (predefinedLogPath != null) { | ||
| String mainLogPath = predefinedLogPath.replace("%20", " "); | ||
|
|
||
| File mainLogFile = new File(mainLogPath); | ||
| assertTrue(mainLogFile.exists(), "Main log file should exist"); | ||
|
|
||
| File rollingLogFile = new File(mainLogPath + ".1"); | ||
| assertTrue(rollingLogFile.exists(), "Rolling log file should exist"); | ||
|
|
||
| List<String> result = LogUtils.readPartFileContentFromLocal(mainLogPath, 0, 50); | ||
|
|
||
| assertNotNull(result); | ||
| assertTrue(result.size() > 0, "Should have some content from the log files"); | ||
|
|
||
| System.out.println("Number of lines read: " + result.size()); | ||
| for (int i = 0; i < Math.min(5, result.size()); i++) { | ||
| System.out.println("Line " + i + ": " + result.get(i)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testReadPartFileContentFromLocal_SkipAll() { | ||
| if (predefinedLogPath != null) { | ||
| String path = predefinedLogPath.replace("%20", " "); | ||
| List<String> result = LogUtils.readPartFileContentFromLocal(path, 1000, 5); | ||
|
|
||
| assertNotNull(result); | ||
| assertTrue(result.isEmpty()); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testReadPartFileContentFromLocal_LimitZero() { | ||
| if (predefinedLogPath != null) { | ||
| String path = predefinedLogPath.replace("%20", " "); | ||
| List<String> result = LogUtils.readPartFileContentFromLocal(path, 0, 0); | ||
|
|
||
| assertNotNull(result); | ||
| assertTrue(result.isEmpty()); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testReadPartFileContentFromLocal_FileDoesNotExist() { | ||
| assertThrows(RuntimeException.class, () -> { | ||
| LogUtils.readPartFileContentFromLocal("/non/existent/file.log", 0, 5); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| public void testReadPartFileContentFromTwoSpecificRollingFiles() { | ||
| String resourcePath = "log/730.log"; | ||
| URL resourceUrl = getClass().getClassLoader().getResource(resourcePath); | ||
|
|
||
| if (resourceUrl != null) { | ||
| String mainLogPath = resourceUrl.getPath().replace("%20", " "); | ||
|
|
||
| File mainLogFile = new File(mainLogPath); | ||
| File rollingLogFile = new File(mainLogPath + ".1"); | ||
|
|
||
| assertTrue(mainLogFile.exists(), "Main log file (730.log) should exist"); | ||
| assertTrue(rollingLogFile.exists(), "Rolling log file (730.log.1) should exist"); | ||
|
|
||
| List<String> result = LogUtils.readPartFileContentFromLocal(mainLogPath, 0, 100); | ||
|
|
||
| assertNotNull(result); | ||
| assertTrue(result.size() > 0, "Should read content from both log files"); | ||
|
|
||
| System.out.println("Total lines from both files (730.log and 730.log.1): " + result.size()); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetFileContentBytesWithRollingLogs() { | ||
| String resourcePath = "log/730.log"; | ||
| URL resourceUrl = getClass().getClassLoader().getResource(resourcePath); | ||
|
|
||
| if (resourceUrl != null) { | ||
| String mainLogPath = resourceUrl.getPath().replace("%20", " "); | ||
|
|
||
| File mainLogFile = new File(mainLogPath); | ||
| File rollingLogFile = new File(mainLogPath + ".1"); | ||
|
|
||
| assertTrue(mainLogFile.exists(), "Main log file (730.log) should exist"); | ||
| assertTrue(rollingLogFile.exists(), "Rolling log file (730.log.1) should exist"); | ||
|
|
||
| byte[] result = LogUtils.getFileContentBytesWithRollingLogs(mainLogPath); | ||
|
|
||
| assertNotNull(result); | ||
| assertTrue(result.length > 0, "Should read bytes from both log files"); | ||
|
|
||
| System.out.println("Total bytes from both files (730.log and 730.log.1): " + result.length); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| 11 | ||
| 12 | ||
| 13 | ||
| 14 | ||
| 15 | ||
| ===============end=============== | ||
| 2026-01-29 15:10:58.538 INFO - process has exited. execute path:/data01/dolphinscheduler/exec/process/730, processId:1167097 ,exitStatusCode:0 ,processWaitForStatus:true ,processExitValue:0 | ||
| 2026-01-29 15:10:58.668 INFO - 🐬 Finalize Task Instance | ||
| 2026-01-29 15:10:58.669 INFO - Clearing task execution path: /data01/dolphinscheduler/exec/process/730 | ||
| 2026-01-29 15:10:58.669 INFO - Successfully cleared task execution path: /data01/dolphinscheduler/exec/process/730 | ||
| 2026-01-29 15:10:58.669 INFO - FINALIZE_SESSION | ||
| 2026-01-29 15:10:58.670 INFO - Deleted task exec directory: /data01/dolphinscheduler/exec/process/730 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.