Skip to content

[Improvement-17843][Master] Add IT case for task timeout alert#18001

Open
shrihari7396 wants to merge 6 commits intoapache:devfrom
shrihari7396:feature/17843-task-timeout-alert-it
Open

[Improvement-17843][Master] Add IT case for task timeout alert#18001
shrihari7396 wants to merge 6 commits intoapache:devfrom
shrihari7396:feature/17843-task-timeout-alert-it

Conversation

@shrihari7396
Copy link

Closes #17843

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 25, 2026

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

// This test intentionally leaves the workflow running, so we skip the resource cleanup check.
// masterContainer.assertAllResourceReleased();
}
@Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid unnessnary change.

@shrihari7396 shrihari7396 force-pushed the feature/17843-task-timeout-alert-it branch from 2361ef0 to c6f6ed8 Compare February 26, 2026 04:44
@shrihari7396 shrihari7396 changed the title [Improvement][Master] Add IT case for task timeout alert [Improvement-17843][Master] Add IT case for task timeout alert Feb 26, 2026
@shrihari7396
Copy link
Author

Hi @SbloodyS,

Thank you for the review. This is my first contribution to this project, so I really appreciate your guidance.
I will fix the requested changes and update the PR shortly.

Thanks!

@shrihari7396
Copy link
Author

Hi @SbloodyS,

The milestone-label-check is currently failing because no milestone and valid label are assigned to this PR.

Could you please help assign the appropriate milestone and label so the check can pass?

Thank you!

@SbloodyS
Copy link
Member

Hi @SbloodyS,

The milestone-label-check is currently failing because no milestone and valid label are assigned to this PR.

Could you please help assign the appropriate milestone and label so the check can pass?

Thank you!

Milestones are required before the merger, and contributors do not need to pay attention to them. You should check failed IT. It did not passed.

@shrihari7396
Copy link
Author

shrihari7396 commented Feb 26, 2026

Hi @SbloodyS,

I would like to work on adding the integration test case for task timeout alert in the master module.

While preparing the environment, my IDE formatter modified some files unintentionally. I will revert any unrelated formatting changes and ensure only the relevant test case changes are included in the PR.

I will first analyze the current timeout handling and alert triggering flow to ensure the IT covers the correct execution path (timeout detection → task state update → alert creation).

Please let me know if there are any specific scenarios or timeout strategies (e.g., WARN vs FAILED) that you would like the test to cover.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Master] Add IT case for task timeout alert

2 participants