Skip to content

fix show backends failed #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catpineapple merged 1 commit into from
Nov 28, 2025
Merged

fix show backends failed #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 50 additions & 50 deletions pkg/common/cmd/util/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
Expand All @@ -30,80 +30,80 @@ import (
"github.com/jmoiron/sqlx"
)

//Client provides abstractions that access doris cluster methods.
// Client provides abstractions that access doris cluster methods.
type Client interface {
ShowFrontends() ([]*cmdtypes.Frontend, error)
ShowBackends() ([]*cmdtypes.Backend, error)
ShowFrontends() ([]*cmdtypes.Frontend, error)
ShowBackends() ([]*cmdtypes.Backend, error)
}

var _ Client = &DorisClient{}

type DorisClient struct {
db *sqlx.DB
db *sqlx.DB
}

func NewDorisClient(dc *DorisConfig) (*DorisClient, error) {
func NewDorisClient(dc *DorisConfig) (*DorisClient, error) {
user := dc.User
password := dc.Password
host := dc.FeHost
queryPort := strconv.Itoa(dc.QueryPort)
dsn := fmt.Sprintf("%s:%s@tcp(%s:%s)/%s", user, password, host, queryPort, "mysql")
dsn := fmt.Sprintf("%s:%s@tcp(%s:%s)/%s", user, password, host, queryPort, "mysql")
rootCertPool := x509.NewCertPool()
if dc.SSLCaPath != "" {
pem, err := os.ReadFile(dc.SSLCaPath)
if err != nil {
return nil, errors.New("read root ca cert failed," + err.Error())
}
if dc.SSLCaPath != "" {
pem, err := os.ReadFile(dc.SSLCaPath)
if err != nil {
return nil, errors.New("read root ca cert failed," + err.Error())
}

if ok := rootCertPool.AppendCertsFromPEM(pem); !ok {
return nil, errors.New("Failed to append ca cert or pem failed.")
}
if ok := rootCertPool.AppendCertsFromPEM(pem); !ok {
return nil, errors.New("Failed to append ca cert or pem failed.")
}

clientCerts := make([]tls.Certificate, 0, 1)
cCert, err := tls.LoadX509KeyPair(dc.SSLCrtPath, dc.SSLKeyPath)
if err != nil {
return nil, errors.New("load x509 key pair failed," + err.Error())
}
clientCerts := make([]tls.Certificate, 0, 1)
cCert, err := tls.LoadX509KeyPair(dc.SSLCrtPath, dc.SSLKeyPath)
if err != nil {
return nil, errors.New("load x509 key pair failed," + err.Error())
}

clientCerts = append(clientCerts, cCert)
if err = mysql.RegisterTLSConfig("doris", &tls.Config{
RootCAs: rootCertPool,
Certificates: clientCerts,
}); err != nil {
return nil, errors.New("register tls config failed," + err.Error())
}
dsn = dsn + "?tls=doris"
}
clientCerts = append(clientCerts, cCert)
if err = mysql.RegisterTLSConfig("doris", &tls.Config{
RootCAs: rootCertPool,
Certificates: clientCerts,
}); err != nil {
return nil, errors.New("register tls config failed," + err.Error())
}
dsn = dsn + "?tls=doris"
}
db, err := sqlx.Open("mysql", dsn)
if err != nil {
return nil, errors.New("NewDorisSqlDB sqlx.Open failed open doris sql client connection, err: " + err.Error())
}

return &DorisClient{
db:db,
}, nil
return &DorisClient{
db: db,
}, nil
}

func(dc *DorisClient) ShowFrontends()([]*cmdtypes.Frontend, error) {
if err := dc.db.Ping(); err != nil {
return nil, err
}
func (dc *DorisClient) ShowFrontends() ([]*cmdtypes.Frontend, error) {
if err := dc.db.Ping(); err != nil {
return nil, err
}

var fs []*cmdtypes.Frontend
if err := dc.db.Select(&fs, "show frontends"); err != nil {
return fs, err
}
return fs, nil
var fs []*cmdtypes.Frontend
if err := dc.db.Unsafe().Select(&fs, "show frontends"); err != nil {
return fs, err
}
return fs, nil
}

func (dc *DorisClient) ShowBackends()([]*cmdtypes.Backend, error) {
if err := dc.db.Ping(); err != nil {
return nil, err
}
func (dc *DorisClient) ShowBackends() ([]*cmdtypes.Backend, error) {
if err := dc.db.Ping(); err != nil {
return nil, err
}

var bs []*cmdtypes.Backend
if err := dc.db.Select(&bs, "show backends"); err != nil {
return bs, err
}
return bs, nil
var bs []*cmdtypes.Backend
if err := dc.db.Unsafe().Select(&bs, "show backends"); err != nil {
return bs, err
}
return bs, nil
}