Skip to content

[feat] support run_mode=debug for ddc fe and ms #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catpineapple merged 1 commit into from
Dec 18, 2025
Merged

[feat] support run_mode=debug for ddc fe and ms #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/controller/sub_controller/disaggregated_cluster/disaggregated_fe/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,9 @@ func (dfc *DisaggregatedFEController) initialFEStatus(ddc *v1.DorisDisaggregated
func (dfc *DisaggregatedFEController) reconcileStatefulset(ctx context.Context, st *appv1.StatefulSet, cluster *v1.DorisDisaggregatedCluster) (*sc.Event, error) {
var est appv1.StatefulSet
if err := dfc.K8sclient.Get(ctx, types.NamespacedName{Namespace: st.Namespace, Name: st.Name}, &est); apierrors.IsNotFound(err) {
// add downlaodAPI volume Mounts
dfc.DisaggregatedSubDefaultController.AddDownwardAPI(st)

if err = k8s.CreateClientObject(ctx, dfc.K8sclient, st); err != nil {
klog.Errorf("disaggregatedFEController reconcileStatefulset create statefulset namespace=%s name=%s failed, err=%s", st.Namespace, st.Name, err.Error())
return &sc.Event{Type: sc.EventWarning, Reason: sc.FECreateResourceFailed, Message: err.Error()}, err
Expand Down Expand Up @@ -324,6 +327,7 @@ func (dfc *DisaggregatedFEController) reconcileStatefulset(ctx context.Context,
ddc_annos := (resource.Annotations)(cluster.Annotations)
msUniqueIdKey := strings.ToLower(fmt.Sprintf(v1.UpdateStatefulsetName, cluster.GetFEStatefulsetName()))
ddc_annos.Add(msUniqueIdKey, "true")
dfc.DisaggregatedSubDefaultController.AddDownwardAPI(st)
}
return equal
}); err != nil {
Expand Down
4 changes: 4 additions & 0 deletions pkg/controller/sub_controller/disaggregated_cluster/metaservice/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,9 @@ func (dms *DisaggregatedMSController) Sync(ctx context.Context, obj client.Objec
func (dms *DisaggregatedMSController) reconcileStatefulset(ctx context.Context, st *appv1.StatefulSet, ddc *v1.DorisDisaggregatedCluster) (*sc.Event, error) {
var est appv1.StatefulSet
if err := dms.K8sclient.Get(ctx, types.NamespacedName{Namespace: st.Namespace, Name: st.Name}, &est); apierrors.IsNotFound(err) {
// add downlaodAPI volume Mounts
dms.DisaggregatedSubDefaultController.AddDownwardAPI(st)

if err = k8s.CreateClientObject(ctx, dms.K8sclient, st); err != nil {
klog.Errorf("dms controller reconcileStatefulset create statefulset namespace=%s name=%s failed, err=%s", st.Namespace, st.Name, err.Error())
return &sc.Event{Type: sc.EventWarning, Reason: sc.CGCreateResourceFailed, Message: err.Error()}, err
Expand Down Expand Up @@ -217,6 +220,7 @@ func (dms *DisaggregatedMSController) reconcileStatefulset(ctx context.Context,
ddc_annos := (resource.Annotations)(ddc.Annotations)
msUniqueIdKey := strings.ToLower(fmt.Sprintf(v1.UpdateStatefulsetName, ddc.GetMSStatefulsetName()))
ddc_annos.Add(msUniqueIdKey, "true")
dms.DisaggregatedSubDefaultController.AddDownwardAPI(st)
}

return equal
Expand Down