[feat] add iceberg publish_changes and order by#3172
[feat] add iceberg publish_changes and order by#3172morningman merged 4 commits intoapache:masterfrom
Conversation
|
run buildall |
morningman
force-pushed
the
feat/iceberg-publish-changes
branch
from
7e0c2bb to
f644e04
Compare
morningman
changed the title
morningman
temporarily deployed
to
Production
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for two new Iceberg features and includes numerous formatting improvements across multiple documentation versions. The changes are synchronized across English and Chinese documentation for both current and versioned docs (3.x and 4.x).
Changes:
- Added documentation for the
publish_changesoperation, which supports the WAP (Write-Audit-Publish) pattern for Iceberg tables - Added documentation for specifying sort columns (ORDER BY clause) when creating Iceberg tables in version 4.1.0+
- Fixed numerous formatting issues including trailing whitespace, inconsistent spacing around equals signs in property definitions, and removed extra blank lines
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| versioned_docs/version-4.x/lakehouse/catalogs/iceberg-catalog.mdx | Added publish_changes operation and ORDER BY documentation in English for version 4.x |
| versioned_docs/version-3.x/lakehouse/catalogs/iceberg-catalog.mdx | Added publish_changes operation and ORDER BY documentation in English for version 3.x |
| i18n/zh-CN/docusaurus-plugin-content-docs/version-4.x/lakehouse/catalogs/iceberg-catalog.mdx | Formatting fixes and full-width character corrections in Chinese version 4.x |
| i18n/zh-CN/docusaurus-plugin-content-docs/version-3.x/lakehouse/catalogs/iceberg-catalog.mdx | Formatting fixes and full-width character corrections in Chinese version 3.x |
| i18n/zh-CN/docusaurus-plugin-content-docs/current/lakehouse/catalogs/iceberg-catalog.mdx | Formatting fixes and full-width character corrections in current Chinese version |
| docs/lakehouse/catalogs/iceberg-catalog.mdx | Added publish_changes operation and ORDER BY documentation in current English version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| **Parameters:** | ||
|
|
There was a problem hiding this comment.
The "Parameters:" heading is duplicated on lines 2576-2578. One of these duplicate headings should be removed.
| **Parameters:** |
| **Parameters:** | ||
|
|
There was a problem hiding this comment.
The "Parameters:" heading is duplicated on lines 2576-2578. One of these duplicate headings should be removed.
| **Parameters:** |
| **Parameters:** | ||
|
|
There was a problem hiding this comment.
The "Parameters:" heading is duplicated on lines 2576-2578. One of these duplicate headings should be removed.
| **Parameters:** |
| Starting from version 4.1.0, Doris supports specifying sort columns when creating an Iceberg table. When writing data, the data will be sorted according to the specified sort columns to achieve better query performance. | ||
|
|
||
| ```sql | ||
| CREATE TABLE ordered_table ( | ||
| `id` int NULL, | ||
| `name` text NULL, | ||
| `score` double NULL, | ||
| `create_time` datetimev2(6) NULL | ||
| ) | ||
| ORDER BY (`id` ASC NULLS FIRST, `score` DESC NULLS LAST) | ||
| PROPERTIES ( |
There was a problem hiding this comment.
The documentation states this feature is available "Starting from version 4.1.0", but this documentation is being added to the version-3.x documentation files. If this feature is not actually available in version 3.x, this documentation should not be added to the version-3.x files. Additionally, the PR description indicates that 3.x is not checked, which conflicts with the changes being made to version-3.x files.
Issue Number: apache/doris#56002
Related PR:
apache/doris#58755
apache/doris#60684
Versions
Languages
Docs Checklist