-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhancement] (nereids) add sync table command #55062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 33922 ms |
TPC-DS: Total hot run time: 185052 ms |
ClickBench: Total hot run time: 32.96 s |
|
Wait wal empty may be time consuming, because data may comes into doris continuously. We should wait for finishing of started group commit backgroup loads. |
felixwluo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
cfee75b to
55bed10
Compare
|
run buildall |
TPC-H: Total hot run time: 1498 ms |
TPC-DS: Total hot run time: 2798 ms |
ClickBench: Total hot run time: 0.06 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
| long tableId = table.getId(); | ||
| GlobalTransactionMgrIface txnMgr = Env.getCurrentGlobalTransactionMgr(); | ||
| // get table transaction ids | ||
| Map<Long, List<Long>> txnIdToTableIds = txnMgr.getDbRunningTransInfo(dbId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in cloud mode, getDbRunningTransInfo is not implemented and return an empty map
|
|
||
| @Override | ||
| public RedirectStatus toRedirectStatus() { | ||
| return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should return FORWARD_WITH_SYNC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you're right, sync table should execute by master
|
run buildall |
|
run buildall |
TPC-DS: Total hot run time: 190846 ms |
ClickBench: Total hot run time: 30.77 s |
FE Regression Coverage ReportIncrement line coverage |
|
Please handle cloud mode . |
What problem does this PR solve?
Issue Number: close: #53017
Problem Summary:
Add sync table command for async group commit, it will return when group commit finishes.
Release note
Add support and regression test for
SYNC TABLEcommand for async group commit.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)