Skip to content

[fix](sql cache) Fix enable sql cache lead to FE Full GC or OOM #49424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lide-reed merged 2 commits into from
Mar 25, 2025
Merged

[fix](sql cache) Fix enable sql cache lead to FE Full GC or OOM #49424

lide-reed merged 2 commits into from
Mar 25, 2025

Conversation

@cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Mar 24, 2025

pick #22645 and #22769 to branch-1.2

cambyzju and others added 2 commits March 24, 2025 20:36
@cambyzju
[fix](cache) add sql cache conf cache_result_max_data_size (apache#…
ae8a30f 
…22645)

Only the maximum number of rows in sql cache cache_result_max_row_count is not enough. If a row of data is too large, FE may OOM.
@xinyiZzz @cambyzju
[fix](cache) Fix enable sql cache lead to FE Full GC or OOM apache#22769
e4745da
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@lide-reed lide-reed self-requested a review March 25, 2025 13:38
lide-reed
lide-reed approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lide-reed lide-reed merged commit 1deb9d1 into apache:branch-1.2-lts Mar 25, 2025
15 of 16 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lide-reed lide-reed lide-reed approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cambyzju @hello-stephen @lide-reed @xinyiZzz