Skip to content

[improve](hll):using neon to merge hll registers #54219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Max-Cheng wants to merge 1 commit into from
Closed

[improve](hll):using neon to merge hll registers #54219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions be/src/olap/hll.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@

#ifdef __x86_64__
#include <immintrin.h>
#elif __aarch64__
#include <arm_neon.h>
#endif

#include "vec/common/hash_table/phmap_fwd_decl.h"
Expand Down Expand Up @@ -287,6 +289,17 @@ class HyperLogLog {
src += 32;
dst += 32;
}
#elif __aarch64__
int loop = HLL_REGISTERS_COUNT / 16;
uint8_t* dst = _registers;
const uint8_t* src = other_registers;
for (int i = 0; i < loop; i++) {
uint8x16_t va = vld1q_u8(dst);
uint8x16_t vb = vld1q_u8(src);
vst1q_u8(dst, vmaxq_u8(va, vb));
src += 16;
dst += 16;
}
#else
for (int i = 0; i < HLL_REGISTERS_COUNT; ++i) {
_registers[i] =
Expand Down
Loading