Skip to content

[feat](checker) Add table/partition version key consistency checking for checker #54527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[feat](checker) Add table/partition version key consistency checking for checker #54527

wants to merge 3 commits into from

Conversation

wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Aug 10, 2025 •
edited
Loading

  1. meta checker: check if the partition and table of the version key exist in the fe meta

  2. checker: check whether the version of the version key is reasonable. The version of the table should be greater than the version of all its partitions.

  3. fix wrong checking for schema key

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat wyxxxcat changed the title [feat](checker) Add version key consistency checking for checker [feat](checker) Add table/partition version key consistency checking for checker Aug 10, 2025
@wyxxxcat
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.86% (1417/1731)
Line Coverage 66.21% (24319/36728)
Region Coverage 67.49% (12107/17938)
Branch Coverage 57.29% (6356/11094)

@wyxxxcat
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.36% (1418/1701)
Line Coverage 66.70% (24290/36415)
Region Coverage 67.98% (12116/17822)
Branch Coverage 57.53% (6358/11052)

@wyxxxcat wyxxxcat marked this pull request as draft August 12, 2025 04:40
@wyxxxcat wyxxxcat marked this pull request as ready for review August 12, 2025 06:55
@wyxxxcat
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 1.14% (1/88) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.45% (1422/1704)
Line Coverage 66.67% (24217/36324)
Region Coverage 67.76% (12080/17828)
Branch Coverage 57.29% (6337/11062)

@wyxxxcat
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 65.91% (58/88) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.62% (1434/1715)
Line Coverage 66.94% (24590/36735)
Region Coverage 68.03% (12266/18030)
Branch Coverage 57.60% (6442/11184)

wyxxxcat
wyxxxcat commented Aug 19, 2025
View reviewed changes
wyxxxcat
wyxxxcat commented Aug 19, 2025
View reviewed changes
@wyxxxcat
Copy link
Contributor Author

run buildall

dataroaring
dataroaring approved these changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@wyxxxcat
Copy link
Contributor Author

run cloudut

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 65.91% (58/88) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.53% (1420/1700)
Line Coverage 66.98% (25305/37780)
Region Coverage 68.11% (12621/18531)
Branch Coverage 57.84% (6682/11552)

@wyxxxcat
Copy link
Contributor Author

run cloud_p0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wyxxxcat @hello-stephen @doris-robot @dataroaring