Skip to content

[fix](decimal) fix wrong result of decimal divide #54537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

[fix](decimal) fix wrong result of decimal divide #54537

merged 1 commit into from
Aug 11, 2025
+20 −6

Conversation

jacktengg
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@jacktengg jacktengg requested a review from yiguolei as a code owner August 11, 2025 01:43
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@jacktengg
Copy link
Contributor Author

run buildall

@jacktengg jacktengg force-pushed the 2.1-fix-decimal-divide branch from a8972cb to 68e4598 Compare August 11, 2025 02:06
@jacktengg
Copy link
Contributor Author

run buildall

@jacktengg jacktengg mentioned this pull request Aug 11, 2025
Merged
16 tasks
@jacktengg jacktengg force-pushed the 2.1-fix-decimal-divide branch from 68e4598 to ff9408a Compare August 11, 2025 02:32
@jacktengg
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.09% (10348/26471)
Line Coverage 30.09% (86007/285865)
Region Coverage 28.81% (44456/154322)
Branch Coverage 25.51% (22749/89162)

@yiguolei yiguolei merged commit d59f081 into apache:branch-2.1 Aug 11, 2025
19 of 20 checks passed
morrySnow pushed a commit that referenced this pull request Aug 13, 2025
@jacktengg
branch-3.1: [fix](decimal) fix wrong result of decimal divide (#54538)
6a029c9 
### What problem does this PR solve?

This problem does not exists in master branch, maybe already fixed by
recent refactoring.
Fro branch 2.1 #54537
Fro branch 3.0 #54453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacktengg @hello-stephen @yiguolei