[fix](audit log) fix audit log return rows incorrect when statement need forward #54548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33975 ms |
TPC-DS: Total hot run time: 169827 ms |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
liaoxin01
reviewed
Aug 11, 2025
ClickBench: Total hot run time: 35.08 s |
sollhui
force-pushed
the
fix_stmt_forward
branch
from
396edc2 to
a7c4ae1
Compare
github-actions
bot
removed
the
approved
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 33754 ms |
TPC-DS: Total hot run time: 170191 ms |
ClickBench: Total hot run time: 35.06 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2025
…eed forward (#54548) ### What problem does this PR solve? If insert into request to follower, ReturnRows in audit log always 0: ``` [query] |QueryId=178cb3b149684de9-87f3c24149b1e50b|Timestamp=2025-08-11 11:53:30.132|Client=174.58.0.1:59086|User=root|FeIp=174.58.1.2|Ctl=internal|Db=test_insert_from_follower|State=OK|ErrorCode=0|ErrorMessage=|Time(ms)=145|CpuTimeMS=0|PeakMemoryBytes=1025152|ScanBytes=0|ScanRows=0|ReturnRows=0|ShuffleSendRows=0|ShuffleSendBytes=0|SpillWriteBytesToLocalStorage=0|SpillReadBytesFromLocalStorage=0|ScanBytesFromLocalStorage=0|ScanBytesFromRemoteStorage=0|ParseTimeMs=9|PlanTimesMs={"plan":-1,"garbage_collect":-1,"lock_tables":-1,"analyze":-1,"rewrite":-1,"fold_const_by_be":0,"collect_partitions":-1,"optimize":-1,"translate":-1,"init_scan_node":-1,"finalize_scan_node":-1,"create_scan_range":-1,"distribute":-1}|GetMetaTimesMs={"get_partition_version_time_ms":0,"get_partition_version_count_has_data":0,"get_partition_version_count":0,"get_table_version_time_ms":0,"get_table_version_count":0}|ScheduleTimesMs={"schedule_time_ms":-1,"fragment_assign_time_ms":-1,"fragment_serialize_time_ms":-1,"fragment_rpc_phase_1_time_ms":-1,"fragment_rpc_phase_2_time_ms":-1,"fragment_compressed_size_byte":0.0,"fragment_rpc_count":0}|HitSqlCache=false|isHandledInFe=false|queriedTablesAndViews=|chosenMViews=|ChangedVariables={"character_set_results":"NULL","sql_mode":"ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES"}|FuzzyVariables=|SqlMode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES|CommandType=Query|StmtType=INSERT|StmtId=27|SqlHash=fb91c45fdb1cfed22fb12838a979dea9|SqlDigest=|IsQuery=false|IsNereids=true|IsInternal=false|WorkloadGroup=|ComputeGroupName=UNKNOWN|Stmt= INSERT INTO test_insert_from_follower_tbl (k1, k2) VALUES (1, "a"), (2, "b"), (3, "c"), (4, "e"); ``` ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
morrySnow
pushed a commit
that referenced
this pull request
Aug 13, 2025
… statement need forward #54548 (#54580) Cherry-picked from #54548 Co-authored-by: hui lai <[email protected]>
sollhui
added a commit
to sollhui/doris
that referenced
this pull request
Aug 20, 2025
…eed forward (apache#54548) If insert into request to follower, ReturnRows in audit log always 0: ``` [query] |QueryId=178cb3b149684de9-87f3c24149b1e50b|Timestamp=2025-08-11 11:53:30.132|Client=174.58.0.1:59086|User=root|FeIp=174.58.1.2|Ctl=internal|Db=test_insert_from_follower|State=OK|ErrorCode=0|ErrorMessage=|Time(ms)=145|CpuTimeMS=0|PeakMemoryBytes=1025152|ScanBytes=0|ScanRows=0|ReturnRows=0|ShuffleSendRows=0|ShuffleSendBytes=0|SpillWriteBytesToLocalStorage=0|SpillReadBytesFromLocalStorage=0|ScanBytesFromLocalStorage=0|ScanBytesFromRemoteStorage=0|ParseTimeMs=9|PlanTimesMs={"plan":-1,"garbage_collect":-1,"lock_tables":-1,"analyze":-1,"rewrite":-1,"fold_const_by_be":0,"collect_partitions":-1,"optimize":-1,"translate":-1,"init_scan_node":-1,"finalize_scan_node":-1,"create_scan_range":-1,"distribute":-1}|GetMetaTimesMs={"get_partition_version_time_ms":0,"get_partition_version_count_has_data":0,"get_partition_version_count":0,"get_table_version_time_ms":0,"get_table_version_count":0}|ScheduleTimesMs={"schedule_time_ms":-1,"fragment_assign_time_ms":-1,"fragment_serialize_time_ms":-1,"fragment_rpc_phase_1_time_ms":-1,"fragment_rpc_phase_2_time_ms":-1,"fragment_compressed_size_byte":0.0,"fragment_rpc_count":0}|HitSqlCache=false|isHandledInFe=false|queriedTablesAndViews=|chosenMViews=|ChangedVariables={"character_set_results":"NULL","sql_mode":"ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES"}|FuzzyVariables=|SqlMode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES|CommandType=Query|StmtType=INSERT|StmtId=27|SqlHash=fb91c45fdb1cfed22fb12838a979dea9|SqlDigest=|IsQuery=false|IsNereids=true|IsInternal=false|WorkloadGroup=|ComputeGroupName=UNKNOWN|Stmt= INSERT INTO test_insert_from_follower_tbl (k1, k2) VALUES (1, "a"), (2, "b"), (3, "c"), (4, "e"); ``` None - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
29 tasks
dataroaring
pushed a commit
that referenced
this pull request
Aug 20, 2025
… statement need forward (#54548) (#55053) pick #54548 If insert into request to follower, ReturnRows in audit log always 0: ``` [query] |QueryId=178cb3b149684de9-87f3c24149b1e50b|Timestamp=2025-08-11 11:53:30.132|Client=174.58.0.1:59086|User=root|FeIp=174.58.1.2|Ctl=internal|Db=test_insert_from_follower|State=OK|ErrorCode=0|ErrorMessage=|Time(ms)=145|CpuTimeMS=0|PeakMemoryBytes=1025152|ScanBytes=0|ScanRows=0|ReturnRows=0|ShuffleSendRows=0|ShuffleSendBytes=0|SpillWriteBytesToLocalStorage=0|SpillReadBytesFromLocalStorage=0|ScanBytesFromLocalStorage=0|ScanBytesFromRemoteStorage=0|ParseTimeMs=9|PlanTimesMs={"plan":-1,"garbage_collect":-1,"lock_tables":-1,"analyze":-1,"rewrite":-1,"fold_const_by_be":0,"collect_partitions":-1,"optimize":-1,"translate":-1,"init_scan_node":-1,"finalize_scan_node":-1,"create_scan_range":-1,"distribute":-1}|GetMetaTimesMs={"get_partition_version_time_ms":0,"get_partition_version_count_has_data":0,"get_partition_version_count":0,"get_table_version_time_ms":0,"get_table_version_count":0}|ScheduleTimesMs={"schedule_time_ms":-1,"fragment_assign_time_ms":-1,"fragment_serialize_time_ms":-1,"fragment_rpc_phase_1_time_ms":-1,"fragment_rpc_phase_2_time_ms":-1,"fragment_compressed_size_byte":0.0,"fragment_rpc_count":0}|HitSqlCache=false|isHandledInFe=false|queriedTablesAndViews=|chosenMViews=|ChangedVariables={"character_set_results":"NULL","sql_mode":"ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES"}|FuzzyVariables=|SqlMode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES|CommandType=Query|StmtType=INSERT|StmtId=27|SqlHash=fb91c45fdb1cfed22fb12838a979dea9|SqlDigest=|IsQuery=false|IsNereids=true|IsInternal=false|WorkloadGroup=|ComputeGroupName=UNKNOWN|Stmt= INSERT INTO test_insert_from_follower_tbl (k1, k2) VALUES (1, "a"), (2, "b"), (3, "c"), (4, "e"); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If insert into request to follower, ReturnRows in audit log always 0:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)