Skip to content

[fix](coordinator) try cancel when Coordinator.exec() throw exception #58872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
924060929 wants to merge 2 commits into from
Closed

[fix](coordinator) try cancel when Coordinator.exec() throw exception #58872

924060929 wants to merge 2 commits into from

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Dec 9, 2025

What problem does this PR solve?

try cancel when Coordinator.exec() throw exception

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

924060929 commented Dec 9, 2025

run buildall

@924060929
Copy link
Contributor Author

924060929 commented Dec 9, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 9, 2025

TPC-H: Total hot run time: 36450 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 28c3021611958b59f45f36abc75d22a394f92936, data reload: false

------ Round 1 ----------------------------------
q1	17668	5134	4951	4951
q2	2039	378	243	243
q3	10140	1392	764	764
q4	10214	859	326	326
q5	7694	2174	1975	1975
q6	201	174	143	143
q7	1024	858	725	725
q8	9370	1469	1234	1234
q9	7304	5339	5313	5313
q10	6905	2423	1968	1968
q11	536	319	310	310
q12	701	736	574	574
q13	17796	3774	3032	3032
q14	303	290	281	281
q15	599	517	508	508
q16	929	901	873	873
q17	719	843	566	566
q18	7394	7106	7116	7106
q19	1384	975	646	646
q20	417	385	257	257
q21	4292	4033	3705	3705
q22	1083	1002	950	950
Total cold run time: 108712 ms
Total hot run time: 36450 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5074	4987	4958	4958
q2	334	413	314	314
q3	2170	2722	2261	2261
q4	1338	1799	1276	1276
q5	4985	4654	4557	4557
q6	217	181	136	136
q7	2027	1982	1755	1755
q8	2692	2517	2655	2517
q9	7597	7523	7486	7486
q10	3089	3484	2849	2849
q11	574	530	490	490
q12	716	741	613	613
q13	3690	4059	3492	3492
q14	294	315	296	296
q15	572	551	503	503
q16	903	946	890	890
q17	1243	1432	1373	1373
q18	8108	7716	7388	7388
q19	871	865	846	846
q20	1910	1975	1807	1807
q21	4676	4306	4161	4161
q22	1086	1024	1001	1001
Total cold run time: 54166 ms
Total hot run time: 50969 ms

@doris-robot
Copy link

doris-robot commented Dec 9, 2025

TPC-DS: Total hot run time: 181996 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 28c3021611958b59f45f36abc75d22a394f92936, data reload: false

query5	5122	625	492	492
query6	349	231	226	226
query7	4213	466	289	289
query8	316	260	249	249
query9	8789	2640	2623	2623
query10	559	383	328	328
query11	15338	14842	14882	14842
query12	196	119	115	115
query13	1261	520	405	405
query14	6417	3324	3095	3095
query14_1	3035	2918	2955	2918
query15	206	195	182	182
query16	787	482	476	476
query17	1109	703	577	577
query18	2714	432	335	335
query19	235	232	210	210
query20	120	114	112	112
query21	222	132	113	113
query22	3890	3870	3910	3870
query23	16761	16058	16021	16021
query23_1	16013	16019	16017	16017
query24	7449	1647	1244	1244
query24_1	1261	1264	1260	1260
query25	576	516	451	451
query26	1253	281	172	172
query27	2734	497	320	320
query28	4470	2186	2169	2169
query29	875	588	471	471
query30	317	246	217	217
query31	849	714	635	635
query32	79	68	70	68
query33	555	358	307	307
query34	921	940	565	565
query35	781	833	739	739
query36	869	904	813	813
query37	136	95	80	80
query38	3859	3871	3800	3800
query39	756	746	718	718
query39_1	698	695	715	695
query40	233	146	131	131
query41	72	72	80	72
query42	107	107	110	107
query43	436	447	426	426
query44	1392	776	771	771
query45	195	191	187	187
query46	915	991	636	636
query47	1639	1724	1627	1627
query48	328	347	255	255
query49	660	455	385	385
query50	686	301	231	231
query51	4035	3890	3878	3878
query52	113	113	103	103
query53	328	362	308	308
query54	301	282	270	270
query55	82	80	77	77
query56	340	314	316	314
query57	1150	1148	1094	1094
query58	284	266	269	266
query59	2367	2391	2284	2284
query60	331	337	314	314
query61	193	215	167	167
query62	722	683	621	621
query63	328	300	304	300
query64	5019	1332	1022	1022
query65	4047	3946	3940	3940
query66	1400	449	326	326
query67	15698	14937	14684	14684
query68	8369	1037	744	744
query69	489	347	306	306
query70	1055	1041	977	977
query71	385	315	292	292
query72	6186	4924	4951	4924
query73	677	582	316	316
query74	8930	8864	8704	8704
query75	3575	3563	3187	3187
query76	3924	1141	769	769
query77	523	380	302	302
query78	9427	9718	8771	8771
query79	1682	887	610	610
query80	737	671	569	569
query81	539	272	240	240
query82	222	131	105	105
query83	257	255	245	245
query84	274	125	105	105
query85	928	509	469	469
query86	385	302	287	287
query87	4194	4086	3997	3997
query88	3222	2291	2307	2291
query89	460	432	387	387
query90	2143	165	158	158
query91	173	166	149	149
query92	79	65	64	64
query93	1340	950	570	570
query94	483	318	291	291
query95	578	390	306	306
query96	598	465	207	207
query97	2596	2642	2580	2580
query98	212	190	192	190
query99	1255	1342	1216	1216
Total cold run time: 265172 ms
Total hot run time: 181996 ms

@doris-robot
Copy link

doris-robot commented Dec 9, 2025

ClickBench: Total hot run time: 27.59 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 28c3021611958b59f45f36abc75d22a394f92936, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.04	0.04
query3	0.26	0.08	0.08
query4	1.60	0.12	0.11
query5	0.28	0.25	0.26
query6	1.18	0.63	0.62
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.58	0.51	0.49
query10	0.56	0.57	0.55
query11	0.16	0.12	0.11
query12	0.16	0.11	0.11
query13	0.62	0.61	0.61
query14	0.98	1.00	0.98
query15	0.83	0.79	0.80
query16	0.41	0.40	0.40
query17	1.02	1.05	1.09
query18	0.23	0.21	0.21
query19	1.94	1.89	1.80
query20	0.02	0.02	0.01
query21	15.43	0.28	0.14
query22	5.02	0.04	0.04
query23	16.06	0.28	0.10
query24	1.31	0.50	0.57
query25	0.07	0.06	0.05
query26	0.14	0.14	0.13
query27	0.08	0.11	0.05
query28	4.78	1.22	1.02
query29	12.62	3.97	3.21
query30	0.27	0.13	0.12
query31	2.87	0.62	0.41
query32	3.23	0.55	0.46
query33	2.99	3.06	3.06
query34	17.02	5.22	4.56
query35	4.58	4.60	4.56
query36	0.67	0.49	0.50
query37	0.11	0.06	0.06
query38	0.07	0.04	0.04
query39	0.05	0.04	0.04
query40	0.17	0.13	0.14
query41	0.08	0.04	0.03
query42	0.05	0.04	0.03
query43	0.04	0.04	0.03
Total cold run time: 98.79 s
Total hot run time: 27.59 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 9, 2025

FE UT Coverage Report

Increment line coverage 30.00% (3/10) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 9, 2025

FE Regression Coverage Report

Increment line coverage 80.00% (8/10) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 9, 2025

FE Regression Coverage Report

Increment line coverage 80.00% (8/10) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

PR approved by anyone and no changes requested.

@924060929 924060929 marked this pull request as draft December 10, 2025 08:25
@924060929 924060929 closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@924060929 @Thearas @doris-robot @hello-stephen @morrySnow