Skip to content

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Jan 5, 2026

pick #58782

What problem does this PR solve?

related issue: #58780

Under the load to 5000-columns wide table, flush memtable consume lots of memory:
image

Set source content column by column when flush memtable for partial update to solve this problem, the memory usage of
_append_block_with_partial_content is hardly visible in the profile after optimization.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

… for partial update (apache#58782)

### What problem does this PR solve?

related issue: apache#58780

Under the load to 5000-columns wide table, flush memtable consume lots
of memory:
<img width="526" height="430" alt="image"
src="https://github.com/user-attachments/assets/816bcc8b-d9d0-4105-a96b-3fbcc931b0b1"
/>

Set source content column by column when flush memtable for partial
update to solve this problem, the memory usage of
`_append_block_with_partial_content` is hardly visible in the profile
after optimization.
@sollhui sollhui requested a review from yiguolei as a code owner January 5, 2026 02:58
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sollhui
Copy link
Contributor Author

sollhui commented Jan 5, 2026

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/15) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.28% (18672/35045)
Line Coverage 39.10% (172991/442434)
Region Coverage 33.79% (133716/395724)
Branch Coverage 34.77% (57818/166304)

@yiguolei yiguolei closed this Jan 5, 2026
@yiguolei yiguolei reopened this Jan 5, 2026
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 633eaee into apache:branch-4.0 Jan 5, 2026
30 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants