Skip to content

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Jan 5, 2026

What problem does this PR solve?

Due to this pull request (#36202), queries encountering BE RPC errors on the cloud will not be retried. Fix it

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 5, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Jan 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

PR approved by anyone and no changes requested.

gavinchou
gavinchou previously approved these changes Jan 5, 2026
@deardeng deardeng dismissed stale reviews from gavinchou and BiteTheDDDDt via 19fc0da January 5, 2026 13:03
@deardeng
Copy link
Contributor Author

deardeng commented Jan 5, 2026

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 5, 2026
@doris-robot
Copy link

TPC-H: Total hot run time: 32435 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 19fc0da3cf1e056cd2b938aa10f16713c6b9bc1c, data reload: false

------ Round 1 ----------------------------------
q1	17617	4186	4075	4075
q2	2054	359	257	257
q3	10117	1310	739	739
q4	10231	907	331	331
q5	7504	2158	1920	1920
q6	202	170	139	139
q7	931	794	645	645
q8	9270	1501	1226	1226
q9	4845	4602	4647	4602
q10	6741	1821	1385	1385
q11	514	298	289	289
q12	713	734	587	587
q13	17758	3835	3180	3180
q14	292	293	267	267
q15	570	519	512	512
q16	699	677	621	621
q17	675	812	588	588
q18	6654	6382	6991	6382
q19	1009	1000	640	640
q20	440	415	288	288
q21	3287	2723	2844	2723
q22	1196	1113	1039	1039
Total cold run time: 103319 ms
Total hot run time: 32435 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4517	4174	4267	4174
q2	362	435	321	321
q3	2279	2796	2467	2467
q4	1431	1854	1473	1473
q5	4592	4338	4335	4335
q6	215	168	131	131
q7	1898	1992	1750	1750
q8	2710	2421	2395	2395
q9	7105	7117	7138	7117
q10	2569	2689	2340	2340
q11	537	465	479	465
q12	720	764	614	614
q13	3636	4131	3152	3152
q14	269	284	254	254
q15	528	488	478	478
q16	629	646	630	630
q17	1092	1281	1299	1281
q18	7475	7232	7229	7229
q19	851	817	809	809
q20	1895	1969	1832	1832
q21	4612	4325	4190	4190
q22	1082	1030	1002	1002
Total cold run time: 51004 ms
Total hot run time: 48439 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173832 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 19fc0da3cf1e056cd2b938aa10f16713c6b9bc1c, data reload: false

query5	4442	584	429	429
query6	351	233	218	218
query7	4217	458	277	277
query8	344	249	245	245
query9	8754	2651	2694	2651
query10	495	370	326	326
query11	15243	15142	15046	15046
query12	178	114	115	114
query13	1266	496	384	384
query14	5579	2985	2752	2752
query14_1	2647	2640	2629	2629
query15	204	193	173	173
query16	962	473	487	473
query17	1115	688	577	577
query18	2431	448	344	344
query19	241	230	195	195
query20	119	118	113	113
query21	218	140	120	120
query22	3891	4105	3980	3980
query23	16315	15672	15617	15617
query23_1	15485	15602	15484	15484
query24	7458	1560	1160	1160
query24_1	1197	1168	1202	1168
query25	555	469	413	413
query26	1248	289	161	161
query27	2739	463	299	299
query28	4541	2151	2150	2150
query29	797	569	461	461
query30	311	244	220	220
query31	782	636	545	545
query32	81	70	68	68
query33	544	359	340	340
query34	902	895	512	512
query35	741	776	689	689
query36	869	872	842	842
query37	131	89	81	81
query38	2692	2650	2657	2650
query39	769	759	733	733
query39_1	709	706	721	706
query40	212	130	125	125
query41	64	60	62	60
query42	108	101	98	98
query43	443	461	427	427
query44	1312	735	722	722
query45	186	183	174	174
query46	842	961	582	582
query47	1391	1438	1432	1432
query48	303	315	229	229
query49	605	416	337	337
query50	628	269	202	202
query51	3848	3772	3809	3772
query52	102	113	94	94
query53	288	318	276	276
query54	275	252	242	242
query55	83	71	80	71
query56	318	295	291	291
query57	1001	1031	951	951
query58	256	289	257	257
query59	2162	2158	2156	2156
query60	332	324	294	294
query61	165	159	163	159
query62	379	342	318	318
query63	299	263	272	263
query64	4988	1315	998	998
query65	3770	3661	3717	3661
query66	1433	399	307	307
query67	15287	15758	15119	15119
query68	8197	979	702	702
query69	502	342	300	300
query70	1018	905	954	905
query71	385	302	274	274
query72	6058	3394	3473	3394
query73	765	720	298	298
query74	8800	8777	8619	8619
query75	2867	2831	2447	2447
query76	3897	1055	638	638
query77	593	363	278	278
query78	9789	9789	9208	9208
query79	1576	859	586	586
query80	629	565	471	471
query81	508	263	225	225
query82	530	147	109	109
query83	256	254	237	237
query84	260	122	104	104
query85	945	502	462	462
query86	390	324	320	320
query87	2845	2848	2775	2775
query88	4317	2240	2246	2240
query89	395	353	334	334
query90	2116	154	140	140
query91	168	165	142	142
query92	88	66	64	64
query93	1646	883	528	528
query94	592	323	285	285
query95	579	321	346	321
query96	576	476	206	206
query97	2369	2420	2267	2267
query98	211	198	195	195
query99	605	592	532	532
Total cold run time: 256227 ms
Total hot run time: 173832 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.69 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 19fc0da3cf1e056cd2b938aa10f16713c6b9bc1c, data reload: false

query1	0.05	0.04	0.04
query2	0.10	0.05	0.04
query3	0.26	0.09	0.09
query4	1.61	0.12	0.11
query5	0.26	0.26	0.27
query6	1.15	0.67	0.65
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.58	0.51	0.50
query10	0.54	0.56	0.55
query11	0.15	0.10	0.11
query12	0.15	0.11	0.11
query13	0.60	0.58	0.60
query14	0.95	0.96	0.94
query15	0.79	0.77	0.78
query16	0.40	0.40	0.43
query17	1.00	1.04	1.07
query18	0.22	0.21	0.22
query19	1.97	1.78	1.81
query20	0.02	0.01	0.02
query21	15.44	0.28	0.14
query22	5.21	0.05	0.04
query23	15.81	0.29	0.10
query24	1.43	0.60	0.19
query25	0.09	0.05	0.07
query26	0.14	0.13	0.14
query27	0.05	0.09	0.06
query28	3.95	1.07	0.88
query29	12.59	3.97	3.17
query30	0.30	0.14	0.11
query31	2.82	0.64	0.40
query32	3.29	0.55	0.48
query33	3.01	2.98	3.07
query34	16.61	5.21	4.44
query35	4.48	4.44	4.53
query36	0.68	0.50	0.49
query37	0.10	0.06	0.07
query38	0.08	0.04	0.03
query39	0.04	0.03	0.03
query40	0.16	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.03	0.02
Total cold run time: 97.34 s
Total hot run time: 26.69 s

@deardeng
Copy link
Contributor Author

deardeng commented Jan 6, 2026

run nonConcurrent

@deardeng
Copy link
Contributor Author

deardeng commented Jan 6, 2026

run p0

@deardeng
Copy link
Contributor Author

deardeng commented Jan 6, 2026

run vault_p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

PR approved by at least one committer and no changes requested.

@hello-stephen hello-stephen merged commit 31ab24b into apache:master Jan 7, 2026
31 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 7, 2026
### What problem does this PR solve?

Due to this pull request (#36202),
queries encountering BE RPC errors on the cloud will not be retried. Fix
it
yiguolei pushed a commit that referenced this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/3.1.x-conflict dev/4.0.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants