Skip to content

Conversation

@zclllyybb
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

sometimes in join we need to do conjunctions for an empty block. that needs a default row. but for the current default value (0000-01-01) for datelike types, it may causea false alarm for date functions. change the default value to make it harder to occur.

before:

mysql> select * from testdt_l where not exists (select f1 from testdt_r where testdt_l.f2 = testdt_r.f2 and (date_sub(testdt_l.f2, interval 8 hour)=testdt_r.f2 or date_sub(testdt_l.f2, interval 16 hour)=testdt_r.f2));
ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.3)[E-218][E-218] Operation hours_add 0 8 out of range

now:

mysql> select * from testdt_l where not exists (select f1 from testdt_r where testdt_l.f2 = testdt_r.f2 and (date_sub(testdt_l.f2, interval 8 hour)=testdt_r.f2 or date_sub(testdt_l.f2, interval 16 hour)=testdt_r.f2));
+------+---------------------+
| f1   | f2                  |
+------+---------------------+
|    1 | 2025-11-21 00:00:00 |
+------+---------------------+

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

run buildall

@zclllyybb zclllyybb force-pushed the fix_default_value_join_31 branch from c07f3b7 to 1e6582e Compare January 5, 2026 16:30
@zclllyybb zclllyybb changed the title [Fix](join) Fix false positive error for date functions in join conjucts branch-3.1: [Fix](join) Fix false positive error for date functions in join conjucts Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants