Skip to content

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Jan 6, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Copilot AI review requested due to automatic review settings January 6, 2026 02:47
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new monitoring metric wal_max_count_per_table to track the maximum number of Write-Ahead Log (WAL) entries per table in the group commit feature.

  • Added global metric g_wal_max_count_per_table to monitor the maximum WAL count across all tables
  • Updated get_wal_queue_size() to calculate and set the new metric when querying all tables (table_id = -1)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jan 6, 2026

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31938 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5f3ffe5c6b554447b7dd3aa581e6d1c0b022d2b0, data reload: false

------ Round 1 ----------------------------------
q1	17673	4258	4071	4071
q2	2083	347	232	232
q3	10204	1283	693	693
q4	10229	866	315	315
q5	7512	2032	1886	1886
q6	187	170	135	135
q7	934	786	652	652
q8	9343	1374	1161	1161
q9	4935	4619	4525	4525
q10	6976	1785	1406	1406
q11	537	300	275	275
q12	704	746	610	610
q13	17780	3842	3093	3093
q14	297	288	279	279
q15	593	516	497	497
q16	663	682	647	647
q17	667	836	471	471
q18	6666	6530	6794	6530
q19	1177	1043	643	643
q20	414	383	277	277
q21	3142	2492	2592	2492
q22	1128	1075	1048	1048
Total cold run time: 103844 ms
Total hot run time: 31938 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4316	4309	4235	4235
q2	339	439	322	322
q3	2271	2833	2428	2428
q4	1435	1801	1422	1422
q5	4442	4349	4335	4335
q6	212	179	130	130
q7	1974	1949	1780	1780
q8	2564	2479	2372	2372
q9	7271	7106	7254	7106
q10	2477	2723	2377	2377
q11	561	487	466	466
q12	701	753	619	619
q13	3609	4150	3132	3132
q14	263	290	253	253
q15	529	496	491	491
q16	647	665	615	615
q17	1090	1266	1230	1230
q18	7464	7512	7130	7130
q19	864	819	824	819
q20	1917	2017	1819	1819
q21	4458	4253	4197	4197
q22	1151	1003	966	966
Total cold run time: 50555 ms
Total hot run time: 48244 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173415 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5f3ffe5c6b554447b7dd3aa581e6d1c0b022d2b0, data reload: false

query5	4505	575	447	447
query6	337	240	217	217
query7	4225	464	269	269
query8	344	248	255	248
query9	8753	2621	2647	2621
query10	467	383	327	327
query11	15255	15297	14925	14925
query12	177	115	118	115
query13	1265	500	375	375
query14	6208	2977	2767	2767
query14_1	2678	2631	2683	2631
query15	205	194	177	177
query16	3303	496	459	459
query17	1100	688	585	585
query18	2207	444	350	350
query19	229	229	203	203
query20	125	116	115	115
query21	292	136	122	122
query22	4134	4056	3960	3960
query23	16062	15767	15564	15564
query23_1	15408	15565	15400	15400
query24	7465	1546	1192	1192
query24_1	1198	1179	1187	1179
query25	582	499	425	425
query26	1207	272	170	170
query27	2752	455	290	290
query28	4525	2139	2144	2139
query29	808	529	438	438
query30	371	244	212	212
query31	859	608	541	541
query32	75	71	64	64
query33	559	347	286	286
query34	879	879	530	530
query35	757	798	701	701
query36	812	814	716	716
query37	150	89	76	76
query38	2739	2710	2600	2600
query39	788	742	729	729
query39_1	721	719	719	719
query40	257	131	116	116
query41	65	61	59	59
query42	109	108	108	108
query43	454	453	418	418
query44	1358	732	728	728
query45	196	184	174	174
query46	853	953	622	622
query47	1389	1407	1294	1294
query48	311	320	245	245
query49	614	402	322	322
query50	639	276	213	213
query51	3811	3898	3766	3766
query52	106	110	98	98
query53	297	326	274	274
query54	293	254	245	245
query55	78	76	73	73
query56	282	286	318	286
query57	1052	946	903	903
query58	266	256	247	247
query59	2167	2229	2096	2096
query60	321	318	291	291
query61	167	159	157	157
query62	387	344	305	305
query63	301	268	270	268
query64	4563	1290	991	991
query65	3724	3799	3719	3719
query66	1354	408	306	306
query67	15529	15606	15191	15191
query68	5492	1018	722	722
query69	502	357	312	312
query70	1063	957	909	909
query71	362	304	280	280
query72	6037	3480	3493	3480
query73	796	740	312	312
query74	8820	8806	8612	8612
query75	2810	2819	2492	2492
query76	3340	1071	637	637
query77	520	391	285	285
query78	9699	9646	9165	9165
query79	1698	847	594	594
query80	645	546	483	483
query81	520	261	227	227
query82	358	149	111	111
query83	262	256	233	233
query84	262	120	106	106
query85	918	507	465	465
query86	383	330	315	315
query87	2815	2915	2779	2779
query88	4381	2242	2253	2242
query89	400	354	333	333
query90	2175	156	149	149
query91	181	166	138	138
query92	80	72	65	65
query93	1922	888	535	535
query94	575	327	259	259
query95	580	370	311	311
query96	579	492	210	210
query97	2318	2373	2271	2271
query98	243	210	205	205
query99	616	603	536	536
Total cold run time: 256221 ms
Total hot run time: 173415 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.83 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5f3ffe5c6b554447b7dd3aa581e6d1c0b022d2b0, data reload: false

query1	0.06	0.04	0.04
query2	0.53	0.05	0.04
query3	0.54	0.09	0.08
query4	1.63	0.11	0.11
query5	0.27	0.26	0.25
query6	1.14	0.67	0.66
query7	0.03	0.03	0.02
query8	0.05	0.03	0.04
query9	0.74	0.51	0.50
query10	0.55	0.54	0.54
query11	0.28	0.09	0.10
query12	0.19	0.11	0.10
query13	0.61	0.59	0.58
query14	0.94	0.95	0.96
query15	0.82	0.79	0.79
query16	0.41	0.40	0.41
query17	0.98	1.07	0.99
query18	0.24	0.21	0.22
query19	1.97	1.90	1.79
query20	0.02	0.02	0.01
query21	15.45	0.27	0.14
query22	5.08	0.07	0.05
query23	16.14	0.29	0.10
query24	6.21	0.81	0.25
query25	0.11	0.08	0.05
query26	0.14	0.13	0.14
query27	0.06	0.08	0.04
query28	4.49	1.04	0.89
query29	12.65	3.88	3.14
query30	0.28	0.13	0.12
query31	2.83	0.65	0.42
query32	3.22	0.57	0.48
query33	3.06	2.95	3.06
query34	16.64	5.16	4.54
query35	4.45	4.49	4.53
query36	0.65	0.50	0.49
query37	0.21	0.07	0.07
query38	0.09	0.04	0.03
query39	0.14	0.03	0.03
query40	0.19	0.15	0.14
query41	0.28	0.04	0.03
query42	0.13	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 104.55 s
Total hot run time: 26.83 s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jan 6, 2026

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31372 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9449f1c446c8ad354c292ebb81a41e531a9e198f, data reload: false

------ Round 1 ----------------------------------
q1	17641	4349	4046	4046
q2	2029	372	245	245
q3	10157	1287	724	724
q4	10205	880	314	314
q5	7643	2158	1924	1924
q6	206	171	139	139
q7	928	798	660	660
q8	9282	1364	1114	1114
q9	5034	4620	4573	4573
q10	6842	1792	1429	1429
q11	521	294	304	294
q12	729	739	594	594
q13	17788	3847	3052	3052
q14	283	312	293	293
q15	605	511	508	508
q16	708	685	617	617
q17	681	837	524	524
q18	6688	6621	6334	6334
q19	1219	966	598	598
q20	402	366	257	257
q21	3014	2477	2177	2177
q22	1071	987	956	956
Total cold run time: 103676 ms
Total hot run time: 31372 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4101	4081	4040	4040
q2	334	401	326	326
q3	2111	2563	2199	2199
q4	1318	1746	1322	1322
q5	4118	4007	4157	4007
q6	213	176	130	130
q7	1913	1810	1814	1810
q8	2629	2461	2366	2366
q9	7428	7088	7187	7088
q10	2543	2774	2353	2353
q11	564	502	458	458
q12	749	777	618	618
q13	3700	4081	3398	3398
q14	387	338	275	275
q15	551	502	516	502
q16	668	670	613	613
q17	1163	1380	1436	1380
q18	8060	7761	7663	7663
q19	1029	871	850	850
q20	1952	2035	2027	2027
q21	4826	4590	4298	4298
q22	1170	1056	1011	1011
Total cold run time: 51527 ms
Total hot run time: 48734 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173306 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9449f1c446c8ad354c292ebb81a41e531a9e198f, data reload: false

query5	4398	576	445	445
query6	339	256	259	256
query7	4249	463	267	267
query8	354	250	244	244
query9	8762	2663	2658	2658
query10	494	374	319	319
query11	15377	15180	14984	14984
query12	179	119	114	114
query13	1279	488	395	395
query14	5846	3084	2818	2818
query14_1	2750	2709	2760	2709
query15	209	193	177	177
query16	974	469	458	458
query17	1108	685	605	605
query18	2443	442	356	356
query19	227	227	222	222
query20	124	118	114	114
query21	210	137	119	119
query22	4130	3983	4065	3983
query23	15929	15656	15372	15372
query23_1	15433	15343	15587	15343
query24	7384	1546	1182	1182
query24_1	1207	1196	1194	1194
query25	543	448	398	398
query26	1235	272	157	157
query27	2754	438	299	299
query28	4582	2138	2134	2134
query29	828	534	438	438
query30	309	243	212	212
query31	791	629	555	555
query32	74	73	64	64
query33	537	337	286	286
query34	892	871	509	509
query35	764	778	698	698
query36	859	885	797	797
query37	125	94	74	74
query38	2744	2814	2645	2645
query39	784	746	732	732
query39_1	706	702	702	702
query40	219	138	118	118
query41	66	64	60	60
query42	113	101	103	101
query43	465	446	422	422
query44	1321	731	724	724
query45	191	182	174	174
query46	850	954	606	606
query47	1375	1466	1279	1279
query48	320	338	240	240
query49	605	413	337	337
query50	632	273	203	203
query51	3837	3857	3799	3799
query52	103	106	96	96
query53	299	327	267	267
query54	301	266	261	261
query55	77	77	72	72
query56	286	290	285	285
query57	993	996	912	912
query58	270	248	250	248
query59	1998	2176	2071	2071
query60	321	313	308	308
query61	179	164	160	160
query62	377	352	325	325
query63	299	266	281	266
query64	5114	1310	993	993
query65	3826	3727	3784	3727
query66	1452	421	307	307
query67	15141	15652	15046	15046
query68	3225	1026	741	741
query69	483	349	310	310
query70	955	915	929	915
query71	354	305	273	273
query72	6073	3405	3543	3405
query73	704	746	299	299
query74	8866	8813	8603	8603
query75	2835	2839	2481	2481
query76	3629	1060	652	652
query77	533	387	277	277
query78	9617	9829	9153	9153
query79	958	915	584	584
query80	641	561	477	477
query81	495	260	229	229
query82	339	154	110	110
query83	270	260	241	241
query84	258	114	103	103
query85	892	509	468	468
query86	334	326	307	307
query87	2867	2882	2767	2767
query88	3195	2259	2242	2242
query89	395	355	330	330
query90	2007	159	158	158
query91	202	187	158	158
query92	74	72	63	63
query93	944	903	532	532
query94	602	351	291	291
query95	578	386	302	302
query96	588	478	207	207
query97	2354	2354	2267	2267
query98	210	207	198	198
query99	598	590	551	551
Total cold run time: 248091 ms
Total hot run time: 173306 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.93 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9449f1c446c8ad354c292ebb81a41e531a9e198f, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.04	0.04
query3	0.26	0.09	0.08
query4	1.62	0.12	0.11
query5	0.27	0.26	0.25
query6	1.16	0.68	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.58	0.51	0.49
query10	0.55	0.56	0.55
query11	0.14	0.10	0.09
query12	0.16	0.11	0.11
query13	0.61	0.59	0.60
query14	0.97	0.96	0.95
query15	0.79	0.77	0.76
query16	0.42	0.40	0.40
query17	1.08	1.01	1.02
query18	0.24	0.21	0.21
query19	1.94	1.90	1.89
query20	0.02	0.02	0.01
query21	15.46	0.28	0.15
query22	5.08	0.05	0.05
query23	16.03	0.29	0.11
query24	1.47	0.36	0.22
query25	0.11	0.06	0.05
query26	0.15	0.15	0.14
query27	0.06	0.05	0.08
query28	3.18	1.05	0.89
query29	12.64	4.00	3.18
query30	0.28	0.14	0.12
query31	2.84	0.66	0.40
query32	3.24	0.57	0.47
query33	3.02	3.02	3.05
query34	16.71	5.14	4.43
query35	4.50	4.50	4.54
query36	0.67	0.50	0.49
query37	0.11	0.07	0.06
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.15	0.13
query41	0.08	0.03	0.03
query42	0.05	0.03	0.04
query43	0.04	0.04	0.03
Total cold run time: 97.05 s
Total hot run time: 26.93 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.23% (18972/35642)
Line Coverage 39.19% (175722/448386)
Region Coverage 33.76% (136162/403313)
Branch Coverage 34.72% (58751/169204)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.85% (25732/34843)
Line Coverage 61.21% (273711/447168)
Region Coverage 56.15% (228776/407433)
Branch Coverage 58.04% (98526/169753)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/4.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants