-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](group commit) add wal_max_count_per_table metric #59583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new monitoring metric wal_max_count_per_table to track the maximum number of Write-Ahead Log (WAL) entries per table in the group commit feature.
- Added global metric
g_wal_max_count_per_tableto monitor the maximum WAL count across all tables - Updated
get_wal_queue_size()to calculate and set the new metric when querying all tables (table_id = -1)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
run buildall |
TPC-H: Total hot run time: 31938 ms |
TPC-DS: Total hot run time: 173415 ms |
ClickBench: Total hot run time: 26.83 s |
|
run buildall |
TPC-H: Total hot run time: 31372 ms |
TPC-DS: Total hot run time: 173306 ms |
ClickBench: Total hot run time: 26.93 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
…9583 (#59612) Cherry-picked from #59583 Co-authored-by: meiyi <[email protected]>
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)