Skip to content

[minor](Prefetch) Revert some useless check #59601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0AyanamiRei wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[minor](Prefetch) Revert some useless check #59601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions be/src/io/fs/buffered_reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,10 +560,6 @@ Status PrefetchBuffer::read_buffer(size_t off, const char* out, size_t buf_len,
reset_offset((off / _size) * _size);
return read_buffer(off, out, buf_len, bytes_read);
}
auto start = std::chrono::steady_clock::now();
// The baseline time is calculated by dividing the size of each buffer by MB/s.
// If it exceeds this value, it is considered a slow I/O operation.
constexpr auto read_time_baseline = std::chrono::seconds(s_max_pre_buffer_size / 1024 / 1024);
{
std::unique_lock lck {_lock};
// buffer must be prefetched or it's closed
Expand All @@ -580,11 +576,6 @@ Status PrefetchBuffer::read_buffer(size_t off, const char* out, size_t buf_len,
return Status::OK();
}
}
auto duration = std::chrono::duration_cast<std::chrono::seconds>(
std::chrono::steady_clock::now() - start);
if (duration > read_time_baseline) [[unlikely]] {
LOG_WARNING("The prefetch io is too slow");
}
RETURN_IF_ERROR(_prefetch_status);
// there is only parquet would do not sequence read
// it would read the end of the file first
Expand Down