Skip to content

branch-4.0: [fix](compaction) Check schema version before ordered data compaction #59570 #59620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jan 8, 2026
Merged

branch-4.0: [fix](compaction) Check schema version before ordered data compaction #59570 #59620

yiguolei merged 1 commit into from
Jan 8, 2026

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Jan 7, 2026

cherry pick from #59570

@zhiqiang-hhhh
[fix](compaction) Check schema version before ordered data compaction (…
0ac9ab7 
…apache#59570)

Ordered data compaction should not be used to accelerate the merging of
rowsets that have undergone a light schema change; otherwise, it may
result in schema-inconsistent segments within the newly generated
rowset.

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [x] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Jan 7, 2026

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 7, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Jan 7, 2026

BE UT Coverage Report

Increment line coverage 81.82% (9/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.29% (18679/35054)
Line Coverage 39.06% (172761/442249)
Region Coverage 33.79% (133712/395750)
Branch Coverage 34.77% (57838/166341)

@yiguolei yiguolei merged commit d1ebe95 into apache:branch-4.0 Jan 8, 2026
23 of 25 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the pick_59570_to_upstream_branch-4.0 branch January 8, 2026 02:01
@zhiqiang-hhhh zhiqiang-hhhh mentioned this pull request Jan 8, 2026
Merged
yiguolei pushed a commit that referenced this pull request Jan 8, 2026
@zhiqiang-hhhh
Revert "branch-4.0: [fix](compaction) Check schema version before ord…
635ed6b 
…ered data compaction #59570" (#59661)

Reverts #59620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhiqiang-hhhh @hello-stephen @doris-robot @yiguolei