-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](filecache) add check and exception handle for empty block file #59646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 32236 ms |
TPC-DS: Total hot run time: 172884 ms |
ClickBench: Total hot run time: 26.85 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
current code didn't check and handle cases when block file is fail to download (empty file). add check and handler for that. Signed-off-by: zhengyu <[email protected]>
39db681 to
b3c82cb
Compare
|
run buildall |
TPC-H: Total hot run time: 31606 ms |
TPC-DS: Total hot run time: 172975 ms |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run p0 |
current code didn't check and handle cases when block file is fail to download (empty file). add check and handler for that.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)