[fix](fe) move variables in Replica and Tablet to reduce memory #59648
+675
−370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mymeiyi
requested review from
dataroaring,
gavinchou and
w41ter
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
There was a problem hiding this comment.
Pull request overview
This PR refactors the Replica and Tablet class hierarchies by moving local-mode-specific variables and logic from the base classes to dedicated subclasses (LocalReplica and LocalTablet), making the codebase more maintainable and better separating concerns between local and cloud modes.
Key Changes:
- Created LocalReplica class to hold local-mode-specific fields (version, backendId, pathHash, etc.) previously in the base Replica class
- Created LocalTablet class methods to override base class methods with local-mode-specific implementations
- Updated GsonUtils serialization to properly handle LocalReplica with backward compatibility for existing "Replica" serialized data
- Converted all direct instantiations of
new Replica()tonew LocalReplica()across test and production code
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| fe/fe-core/src/main/java/org/apache/doris/catalog/Replica.java | Base class refactored to remove local-specific fields, converted methods to throw UnsupportedOperationException or return default values |
| fe/fe-core/src/main/java/org/apache/doris/catalog/LocalReplica.java | New subclass containing all local-mode-specific fields and implementations moved from base Replica class |
| fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java | Base class refactored to remove local-specific fields, methods now throw UnsupportedOperationException or return defaults |
| fe/fe-core/src/main/java/org/apache/doris/catalog/LocalTablet.java | Extended with local-specific fields and method overrides previously in base Tablet class |
| fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java | Updated to instantiate LocalReplica instead of Replica |
| fe/fe-core/src/main/java/org/apache/doris/catalog/EnvFactory.java | Updated factory methods to create LocalReplica instances |
| fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudReplica.java | Added segmentCount and rowsetCount fields with getter/setter overrides for cloud-mode specifics |
| fe/fe-core/src/main/java/org/apache/doris/persist/gson/GsonUtils.java | Updated serialization adapters to register LocalReplica with backward compatibility mappings |
| fe/fe-core/src/main/java/org/apache/doris/master/ReportHandler.java | Changed to instantiate LocalReplica for tablet reporting |
| fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java | Updated replica creation calls to use LocalReplica |
| fe/fe-core/src/main/java/org/apache/doris/clone/*.java | Added documentation comments indicating "Only used in local mode" for various checker/scheduler classes |
| fe/fe-core/src/main/java/org/apache/doris/clone/TabletSchedCtx.java | Updated to create LocalReplica instances |
| fe/fe-core/src/main/java/org/apache/doris/consistency/ConsistencyChecker.java | Added "Only used in local mode" documentation comment |
| fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java | Updated to instantiate LocalReplica for restore operations |
| fe/fe-core/src/test/java/**/*.java | Multiple test files updated to use LocalReplica instead of Replica |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TPC-H: Total hot run time: 31203 ms |
TPC-DS: Total hot run time: 173213 ms |
ClickBench: Total hot run time: 26.62 s |
mymeiyi
force-pushed
the
fix-fe-7.1
branch
2 times, most recently
from
1d0a920 to
6774340
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31416 ms |
TPC-DS: Total hot run time: 173763 ms |
ClickBench: Total hot run time: 26.78 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31840 ms |
TPC-DS: Total hot run time: 172482 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
FE Regression Coverage ReportIncrement line coverage |
gavinchou
approved these changes
Jan 9, 2026
mymeiyi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)