Skip to content

Conversation

@zhiqiang-hhhh
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31863 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 75d7b5eea50de54e07ed7d8be92c1a7bb1a7db4f, data reload: false

------ Round 1 ----------------------------------
q1	17641	4151	4100	4100
q2	2048	347	245	245
q3	10135	1271	712	712
q4	10208	801	304	304
q5	7534	2095	1833	1833
q6	189	172	136	136
q7	953	790	663	663
q8	9281	1391	1169	1169
q9	4969	4529	4697	4529
q10	6732	1808	1434	1434
q11	502	302	289	289
q12	693	762	630	630
q13	17766	3803	3104	3104
q14	304	299	285	285
q15	579	508	505	505
q16	686	700	638	638
q17	647	807	518	518
q18	6709	6475	6436	6436
q19	1110	985	620	620
q20	393	356	254	254
q21	3038	2469	2480	2469
q22	1056	1020	990	990
Total cold run time: 103173 ms
Total hot run time: 31863 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4130	4076	4093	4076
q2	323	428	343	343
q3	2110	2636	2249	2249
q4	1356	1737	1357	1357
q5	4164	3988	4110	3988
q6	209	169	128	128
q7	1907	1764	1729	1729
q8	2859	2546	2421	2421
q9	7220	7241	7248	7241
q10	2626	2739	2635	2635
q11	541	473	451	451
q12	715	805	640	640
q13	3746	4125	3308	3308
q14	316	334	283	283
q15	579	537	520	520
q16	684	711	666	666
q17	1162	1334	1388	1334
q18	8081	8029	7899	7899
q19	847	929	847	847
q20	2079	2144	1914	1914
q21	4869	4578	4329	4329
q22	1097	1063	1082	1063
Total cold run time: 51620 ms
Total hot run time: 49421 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173726 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 75d7b5eea50de54e07ed7d8be92c1a7bb1a7db4f, data reload: false

query5	4547	623	494	494
query6	342	228	223	223
query7	4218	457	263	263
query8	343	242	258	242
query9	8733	2891	2891	2891
query10	491	389	348	348
query11	15319	14971	14987	14971
query12	185	116	116	116
query13	1262	486	397	397
query14	6489	3075	2746	2746
query14_1	2691	2654	2691	2654
query15	202	194	181	181
query16	981	492	462	462
query17	1104	668	561	561
query18	2607	435	345	345
query19	223	226	211	211
query20	133	114	122	114
query21	216	146	117	117
query22	3986	4083	4041	4041
query23	16219	15755	15597	15597
query23_1	15518	15576	15482	15482
query24	7145	1548	1148	1148
query24_1	1149	1163	1188	1163
query25	537	453	409	409
query26	1248	268	155	155
query27	2769	436	282	282
query28	4547	2183	2187	2183
query29	747	505	417	417
query30	324	243	207	207
query31	827	625	565	565
query32	86	74	71	71
query33	520	350	304	304
query34	918	872	536	536
query35	732	782	685	685
query36	858	849	833	833
query37	138	97	88	88
query38	2737	2666	2654	2654
query39	786	763	739	739
query39_1	725	705	700	700
query40	214	141	117	117
query41	68	61	63	61
query42	104	104	108	104
query43	479	493	403	403
query44	1333	751	751	751
query45	185	197	195	195
query46	810	927	570	570
query47	1411	1477	1425	1425
query48	311	336	245	245
query49	598	426	335	335
query50	614	273	202	202
query51	3822	3822	3766	3766
query52	105	108	95	95
query53	290	331	271	271
query54	291	274	277	274
query55	80	82	78	78
query56	306	308	308	308
query57	1053	1059	885	885
query58	279	256	256	256
query59	1957	2165	2081	2081
query60	334	339	316	316
query61	155	147	148	147
query62	399	388	321	321
query63	295	266	263	263
query64	4842	1265	972	972
query65	3829	3766	3798	3766
query66	1408	452	315	315
query67	15667	15461	15497	15461
query68	2408	1088	761	761
query69	449	374	328	328
query70	1029	952	835	835
query71	315	307	288	288
query72	5292	3204	2255	2255
query73	619	734	314	314
query74	8753	8767	8523	8523
query75	2741	2799	2429	2429
query76	2285	1052	655	655
query77	366	365	323	323
query78	9847	10186	9234	9234
query79	1087	896	581	581
query80	899	596	521	521
query81	516	260	235	235
query82	1472	152	112	112
query83	356	269	246	246
query84	259	114	100	100
query85	1075	590	436	436
query86	386	287	284	284
query87	2870	2866	2730	2730
query88	3513	2587	2550	2550
query89	412	354	334	334
query90	1746	180	170	170
query91	167	162	131	131
query92	84	73	75	73
query93	1017	895	547	547
query94	541	308	295	295
query95	582	390	325	325
query96	654	518	230	230
query97	2383	2411	2323	2323
query98	210	206	201	201
query99	608	607	513	513
Total cold run time: 248111 ms
Total hot run time: 173726 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.87 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 75d7b5eea50de54e07ed7d8be92c1a7bb1a7db4f, data reload: false

query1	0.06	0.05	0.05
query2	0.11	0.04	0.04
query3	0.26	0.08	0.08
query4	1.61	0.12	0.11
query5	0.28	0.26	0.26
query6	1.16	0.68	0.65
query7	0.03	0.02	0.03
query8	0.06	0.05	0.04
query9	0.58	0.49	0.50
query10	0.56	0.56	0.54
query11	0.14	0.10	0.10
query12	0.14	0.11	0.12
query13	0.60	0.59	0.58
query14	0.95	0.95	0.95
query15	0.79	0.77	0.79
query16	0.38	0.42	0.41
query17	1.02	1.02	1.03
query18	0.23	0.21	0.21
query19	2.00	1.86	1.86
query20	0.02	0.02	0.02
query21	15.44	0.28	0.14
query22	5.52	0.06	0.04
query23	16.36	0.29	0.10
query24	1.64	0.59	0.33
query25	0.12	0.05	0.05
query26	0.14	0.14	0.14
query27	0.07	0.05	0.08
query28	3.72	1.09	0.88
query29	12.55	3.98	3.11
query30	0.27	0.16	0.12
query31	2.82	0.64	0.40
query32	3.24	0.56	0.46
query33	3.03	3.05	3.06
query34	16.19	5.07	4.41
query35	4.47	4.49	4.43
query36	0.66	0.51	0.50
query37	0.11	0.07	0.06
query38	0.08	0.05	0.03
query39	0.04	0.02	0.03
query40	0.17	0.14	0.14
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 97.81 s
Total hot run time: 26.87 s

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31287 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 75146463e614f415bd89ffd94cb21781ec58eacf, data reload: false

------ Round 1 ----------------------------------
q1	17676	4209	4026	4026
q2	2047	338	242	242
q3	10213	1325	697	697
q4	10223	869	300	300
q5	7466	2215	1834	1834
q6	189	180	145	145
q7	924	787	667	667
q8	9266	1401	1170	1170
q9	5135	4636	4702	4636
q10	6800	1797	1382	1382
q11	513	281	263	263
q12	759	739	596	596
q13	17816	3798	3086	3086
q14	287	290	281	281
q15	585	507	521	507
q16	698	687	619	619
q17	654	832	440	440
q18	6688	6405	6309	6309
q19	1288	980	624	624
q20	388	350	243	243
q21	2987	2423	2251	2251
q22	1028	1012	969	969
Total cold run time: 103630 ms
Total hot run time: 31287 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4148	4091	4048	4048
q2	316	389	337	337
q3	2133	2643	2212	2212
q4	1338	1763	1331	1331
q5	4118	3999	4119	3999
q6	209	175	130	130
q7	1858	1823	1636	1636
q8	2836	2548	2519	2519
q9	7375	7139	7253	7139
q10	2504	2702	2295	2295
q11	563	502	461	461
q12	691	738	593	593
q13	3528	4101	3595	3595
q14	309	303	275	275
q15	566	503	493	493
q16	667	800	618	618
q17	1141	1373	1387	1373
q18	8180	7645	7898	7645
q19	868	831	833	831
q20	1964	2072	1903	1903
q21	4948	4431	4183	4183
q22	1079	1007	981	981
Total cold run time: 51339 ms
Total hot run time: 48597 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173763 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 75146463e614f415bd89ffd94cb21781ec58eacf, data reload: false

query5	4421	648	495	495
query6	344	234	216	216
query7	4232	462	262	262
query8	351	249	239	239
query9	8703	2913	2930	2913
query10	505	421	317	317
query11	15405	15159	14858	14858
query12	183	133	118	118
query13	1258	481	396	396
query14	5963	3053	2812	2812
query14_1	2700	2680	2697	2680
query15	206	194	172	172
query16	977	492	479	479
query17	1091	657	557	557
query18	2434	451	317	317
query19	216	209	184	184
query20	122	111	109	109
query21	215	134	112	112
query22	3825	4138	3827	3827
query23	15892	15874	15306	15306
query23_1	15504	15326	15370	15326
query24	7153	1543	1174	1174
query24_1	1147	1149	1168	1149
query25	515	424	386	386
query26	1245	269	143	143
query27	2770	440	276	276
query28	4560	2180	2155	2155
query29	778	503	411	411
query30	307	238	206	206
query31	783	648	577	577
query32	84	71	71	71
query33	527	351	345	345
query34	885	859	545	545
query35	694	752	658	658
query36	888	881	785	785
query37	133	96	87	87
query38	2701	2670	2718	2670
query39	775	750	733	733
query39_1	725	721	714	714
query40	218	133	117	117
query41	65	66	60	60
query42	106	103	101	101
query43	452	478	412	412
query44	1319	743	748	743
query45	185	188	184	184
query46	831	944	568	568
query47	1449	1530	1414	1414
query48	312	331	231	231
query49	603	426	346	346
query50	634	265	201	201
query51	3787	3790	3786	3786
query52	111	110	95	95
query53	282	317	263	263
query54	297	271	255	255
query55	82	80	75	75
query56	302	305	312	305
query57	1058	1042	994	994
query58	269	256	255	255
query59	2068	2217	1907	1907
query60	338	332	319	319
query61	154	148	141	141
query62	370	361	316	316
query63	295	263	257	257
query64	5009	1252	1010	1010
query65	3834	3711	3732	3711
query66	1464	444	340	340
query67	15489	15622	15457	15457
query68	2430	1107	775	775
query69	455	368	336	336
query70	1028	979	933	933
query71	326	311	297	297
query72	5489	3365	3410	3365
query73	607	716	311	311
query74	8767	8727	8544	8544
query75	2690	2767	2457	2457
query76	2284	1062	659	659
query77	360	393	305	305
query78	9886	9962	9146	9146
query79	1079	873	572	572
query80	1332	561	476	476
query81	557	267	230	230
query82	1032	147	109	109
query83	370	249	232	232
query84	248	115	92	92
query85	899	480	438	438
query86	409	296	283	283
query87	2871	2913	2728	2728
query88	3485	2598	2547	2547
query89	388	340	324	324
query90	1935	161	162	161
query91	165	159	133	133
query92	79	75	65	65
query93	966	920	539	539
query94	627	326	299	299
query95	569	399	339	339
query96	632	501	231	231
query97	2314	2395	2318	2318
query98	203	215	200	200
query99	604	565	526	526
Total cold run time: 246616 ms
Total hot run time: 173763 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 75146463e614f415bd89ffd94cb21781ec58eacf, data reload: false

query1	0.05	0.04	0.04
query2	0.11	0.05	0.05
query3	0.26	0.08	0.08
query4	1.61	0.12	0.11
query5	0.28	0.27	0.28
query6	1.15	0.65	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.57	0.50	0.49
query10	0.54	0.53	0.54
query11	0.14	0.10	0.10
query12	0.15	0.11	0.11
query13	0.60	0.58	0.58
query14	0.95	0.93	0.92
query15	0.78	0.76	0.79
query16	0.39	0.42	0.39
query17	1.00	0.99	1.04
query18	0.24	0.21	0.21
query19	1.86	1.88	1.82
query20	0.02	0.01	0.01
query21	15.44	0.27	0.13
query22	5.13	0.06	0.05
query23	15.89	0.29	0.10
query24	1.41	0.22	1.31
query25	0.13	0.11	0.05
query26	0.16	0.13	0.13
query27	0.08	0.11	0.04
query28	5.01	1.05	0.87
query29	12.53	3.93	3.14
query30	0.28	0.14	0.13
query31	2.82	0.61	0.40
query32	3.24	0.56	0.46
query33	2.97	3.00	3.03
query34	16.24	5.15	4.44
query35	4.46	4.44	4.41
query36	0.66	0.50	0.49
query37	0.11	0.07	0.06
query38	0.07	0.04	0.03
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.02
query42	0.04	0.03	0.04
query43	0.04	0.04	0.04
Total cold run time: 97.8 s
Total hot run time: 26.58 s

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32189 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3241d1a683acdf0511ba54b705ebc930f482c0f3, data reload: false

------ Round 1 ----------------------------------
q1	17617	4259	4073	4073
q2	2068	355	240	240
q3	10146	1322	695	695
q4	10231	903	305	305
q5	7741	2141	1867	1867
q6	214	178	136	136
q7	932	793	673	673
q8	9280	1402	1051	1051
q9	5096	4515	4556	4515
q10	6812	1840	1420	1420
q11	533	301	274	274
q12	743	757	621	621
q13	17814	3853	3134	3134
q14	285	312	282	282
q15	596	516	524	516
q16	701	698	637	637
q17	676	794	549	549
q18	6924	6594	7054	6594
q19	1561	1092	716	716
q20	436	392	264	264
q21	3195	2667	2574	2574
q22	1178	1087	1053	1053
Total cold run time: 104779 ms
Total hot run time: 32189 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4402	4257	4238	4238
q2	335	403	311	311
q3	2297	2850	2534	2534
q4	1493	1840	1438	1438
q5	4604	4368	4404	4368
q6	234	180	131	131
q7	2026	1998	1831	1831
q8	2637	2399	2370	2370
q9	7386	7297	7115	7115
q10	2520	2678	2114	2114
q11	520	451	440	440
q12	646	707	544	544
q13	3336	3817	3103	3103
q14	273	284	256	256
q15	520	499	488	488
q16	617	662	631	631
q17	1086	1239	1261	1239
q18	7575	7480	7245	7245
q19	828	777	813	777
q20	1880	2024	1821	1821
q21	4578	4265	4154	4154
q22	1030	1027	1006	1006
Total cold run time: 50823 ms
Total hot run time: 48154 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174680 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3241d1a683acdf0511ba54b705ebc930f482c0f3, data reload: false

query5	4396	615	502	502
query6	312	214	200	200
query7	4208	469	267	267
query8	359	254	241	241
query9	8708	2890	2886	2886
query10	533	400	343	343
query11	15398	15222	14817	14817
query12	177	119	115	115
query13	1254	485	399	399
query14	6011	3076	2836	2836
query14_1	2689	2646	2710	2646
query15	200	197	171	171
query16	992	501	491	491
query17	1103	653	556	556
query18	2426	434	332	332
query19	229	221	196	196
query20	123	115	113	113
query21	224	138	117	117
query22	4148	4016	4109	4016
query23	16038	15689	15463	15463
query23_1	15490	15517	15545	15517
query24	7233	1561	1188	1188
query24_1	1153	1165	1175	1165
query25	552	449	407	407
query26	1239	269	154	154
query27	2769	446	285	285
query28	4546	2184	2169	2169
query29	803	532	447	447
query30	316	238	208	208
query31	803	671	576	576
query32	87	73	72	72
query33	509	349	306	306
query34	890	875	527	527
query35	740	760	667	667
query36	865	922	852	852
query37	126	102	81	81
query38	2759	2693	2621	2621
query39	768	747	722	722
query39_1	715	741	716	716
query40	213	132	116	116
query41	66	60	62	60
query42	109	101	100	100
query43	445	477	420	420
query44	1329	754	738	738
query45	189	183	177	177
query46	829	956	590	590
query47	1495	1525	1362	1362
query48	340	324	241	241
query49	611	438	344	344
query50	628	264	195	195
query51	3727	3794	3833	3794
query52	102	105	94	94
query53	290	323	268	268
query54	293	266	256	256
query55	80	87	76	76
query56	308	309	302	302
query57	991	998	886	886
query58	273	258	273	258
query59	2005	2091	2059	2059
query60	330	330	304	304
query61	139	139	142	139
query62	420	360	319	319
query63	294	261	260	260
query64	4961	1227	952	952
query65	3835	3704	3803	3704
query66	1447	449	309	309
query67	15515	15601	15440	15440
query68	2442	1099	761	761
query69	436	371	322	322
query70	944	961	969	961
query71	320	310	281	281
query72	5272	3100	3240	3100
query73	595	704	319	319
query74	8892	8762	8559	8559
query75	2730	2820	2472	2472
query76	2263	1063	651	651
query77	353	391	312	312
query78	9711	9909	9157	9157
query79	1044	890	592	592
query80	1210	554	481	481
query81	518	263	227	227
query82	1302	141	113	113
query83	327	251	237	237
query84	246	112	89	89
query85	919	522	497	497
query86	374	307	292	292
query87	2854	2918	2741	2741
query88	3488	2621	2565	2565
query89	374	348	328	328
query90	1920	168	156	156
query91	157	158	135	135
query92	78	75	66	66
query93	931	895	542	542
query94	587	314	303	303
query95	574	329	318	318
query96	643	497	228	228
query97	2343	2361	2321	2321
query98	206	206	198	198
query99	621	579	527	527
Total cold run time: 246760 ms
Total hot run time: 174680 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.11 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3241d1a683acdf0511ba54b705ebc930f482c0f3, data reload: false

query1	0.05	0.04	0.05
query2	0.11	0.05	0.05
query3	0.25	0.09	0.09
query4	1.60	0.11	0.11
query5	0.27	0.25	0.26
query6	1.14	0.68	0.65
query7	0.04	0.03	0.02
query8	0.05	0.04	0.04
query9	0.57	0.49	0.50
query10	0.54	0.55	0.54
query11	0.15	0.10	0.10
query12	0.14	0.10	0.11
query13	0.60	0.59	0.59
query14	0.94	0.95	0.96
query15	0.80	0.78	0.78
query16	0.42	0.42	0.39
query17	0.98	1.09	1.00
query18	0.23	0.21	0.21
query19	1.93	1.82	1.88
query20	0.02	0.01	0.01
query21	15.44	0.27	0.13
query22	5.10	0.05	0.05
query23	15.78	0.28	0.11
query24	1.19	0.39	0.36
query25	0.06	0.08	0.08
query26	0.15	0.14	0.13
query27	0.07	0.06	0.06
query28	3.86	1.08	0.88
query29	12.53	3.95	3.21
query30	0.29	0.13	0.12
query31	2.82	0.63	0.38
query32	3.24	0.56	0.47
query33	3.09	3.18	3.13
query34	15.89	5.12	4.48
query35	4.46	4.51	4.45
query36	0.68	0.50	0.49
query37	0.12	0.06	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.15	0.13
query41	0.09	0.04	0.03
query42	0.04	0.03	0.04
query43	0.05	0.03	0.03
Total cold run time: 96.07 s
Total hot run time: 27.11 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 87.50% (14/16) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.40% (19027/36314)
Line Coverage 35.70% (176268/493751)
Region Coverage 32.25% (136522/423333)
Branch Coverage 33.13% (58998/178083)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 87.50% (14/16) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.50% (25448/35592)
Line Coverage 54.01% (266383/493169)
Region Coverage 51.78% (221521/427835)
Branch Coverage 53.16% (95080/178844)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants