Skip to content

[fix](compaction) Skip ordered data compaction if any input has ann/inverted index. #59714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhiqiang-hhhh wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −0
Open

[fix](compaction) Skip ordered data compaction if any input has ann/inverted index. #59714

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75d7b5e
dev
zhiqiang-hhhh Jan 16, 2026
7514646
fix ut
zhiqiang-hhhh Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions be/src/olap/compaction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,21 @@ bool CompactionMixin::handle_ordered_data_compaction() {
return false;
}

// Skip ordered data compaction if any rowset has inverted/ann index.
for (auto& rowset : _input_rowsets) {
const auto& meta = rowset->rowset_meta();
const auto& schema = meta->tablet_schema();
if (!schema) {
// RowsetMeta should always carry a valid schema in production, but unit tests and
// some auxiliary paths may build rowsets with an empty schema. Ordered data compaction
// must be conservative here to avoid undefined behavior.
return false;
}
if (schema->has_inverted_index() || schema->has_ann_index()) {
return false;
}
}

// If some rowsets has idx files and some rowsets has not, we can not do link file compaction.
// Since the output rowset will be broken.

Expand Down