Skip to content

Conversation

@heguanhui
Copy link
Contributor

@heguanhui heguanhui commented Jan 9, 2026

What problem does this PR solve?

Problem Summary:

Fix Content-Length mismatch issue in RestBaseController forwardToMaster logic because of using RestTemplate.

Check List (For Author)

  • Test

  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

@morningman morningman self-assigned this Jan 11, 2026
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 12, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 31745 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1ac256897d564f428fa419b10aa4c16839d2c304, data reload: false

------ Round 1 ----------------------------------
q1	17625	4294	4092	4092
q2	2018	345	233	233
q3	10194	1293	746	746
q4	10212	895	318	318
q5	7500	2107	1837	1837
q6	193	173	143	143
q7	930	855	667	667
q8	9289	1421	1139	1139
q9	5095	4616	4567	4567
q10	6783	1820	1427	1427
q11	521	293	291	291
q12	731	757	588	588
q13	17776	3853	3114	3114
q14	288	294	276	276
q15	601	531	515	515
q16	697	685	634	634
q17	674	831	510	510
q18	6599	6630	6580	6580
q19	1095	970	601	601
q20	403	371	261	261
q21	3033	2457	2239	2239
q22	1044	999	967	967
Total cold run time: 103301 ms
Total hot run time: 31745 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4131	4088	4082	4082
q2	329	399	320	320
q3	2098	2583	2236	2236
q4	1359	1741	1326	1326
q5	4134	4021	4111	4021
q6	218	174	130	130
q7	1863	1786	1917	1786
q8	2655	2424	2439	2424
q9	7293	7233	7162	7162
q10	2581	2783	2287	2287
q11	621	484	460	460
q12	761	776	638	638
q13	3580	4086	3656	3656
q14	298	313	265	265
q15	547	508	498	498
q16	650	700	643	643
q17	1126	1373	1436	1373
q18	8324	8023	7616	7616
q19	879	874	828	828
q20	1939	2144	2049	2049
q21	4651	4532	4475	4475
q22	1128	1111	997	997
Total cold run time: 51165 ms
Total hot run time: 49272 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173340 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1ac256897d564f428fa419b10aa4c16839d2c304, data reload: false

query5	4678	609	433	433
query6	348	248	229	229
query7	4245	455	267	267
query8	327	253	220	220
query9	8771	2671	2687	2671
query10	514	367	312	312
query11	15132	15277	15006	15006
query12	186	118	118	118
query13	1271	508	379	379
query14	6026	3010	2846	2846
query14_1	2699	2703	2729	2703
query15	211	191	178	178
query16	990	497	464	464
query17	1094	695	613	613
query18	2443	440	355	355
query19	248	229	205	205
query20	124	118	120	118
query21	216	150	120	120
query22	3758	3867	3972	3867
query23	16131	15596	15422	15422
query23_1	15631	15422	15543	15422
query24	7318	1592	1206	1206
query24_1	1200	1216	1211	1211
query25	606	480	427	427
query26	1254	274	158	158
query27	2752	456	287	287
query28	4547	2155	2155	2155
query29	787	569	470	470
query30	312	245	215	215
query31	823	636	550	550
query32	78	74	72	72
query33	551	343	299	299
query34	886	890	518	518
query35	752	757	714	714
query36	872	897	866	866
query37	128	92	79	79
query38	2740	2687	2603	2603
query39	778	749	744	744
query39_1	704	711	718	711
query40	214	137	115	115
query41	66	63	67	63
query42	107	101	106	101
query43	492	458	418	418
query44	1317	704	714	704
query45	184	181	174	174
query46	876	982	594	594
query47	1467	1502	1333	1333
query48	310	326	236	236
query49	608	413	328	328
query50	646	278	194	194
query51	3831	3832	3884	3832
query52	107	107	99	99
query53	291	324	266	266
query54	281	257	246	246
query55	80	79	71	71
query56	287	285	285	285
query57	999	963	947	947
query58	261	248	236	236
query59	2095	2165	2056	2056
query60	308	324	298	298
query61	165	159	155	155
query62	394	375	313	313
query63	301	263	279	263
query64	4903	1329	974	974
query65	3806	3754	3729	3729
query66	1448	441	309	309
query67	15206	14845	15857	14845
query68	6329	1000	700	700
query69	489	345	306	306
query70	1049	880	942	880
query71	361	299	276	276
query72	6077	3365	3453	3365
query73	758	713	299	299
query74	8796	8838	8588	8588
query75	2826	2811	2439	2439
query76	3419	1073	644	644
query77	517	363	275	275
query78	9705	9835	9258	9258
query79	1265	923	593	593
query80	613	592	481	481
query81	527	259	229	229
query82	206	145	110	110
query83	265	256	245	245
query84	260	118	105	105
query85	932	527	461	461
query86	385	300	297	297
query87	2921	2842	2767	2767
query88	3122	2221	2202	2202
query89	387	342	324	324
query90	2186	161	153	153
query91	170	163	146	146
query92	76	69	65	65
query93	1103	934	536	536
query94	591	335	295	295
query95	575	331	295	295
query96	588	473	204	204
query97	2326	2403	2286	2286
query98	209	201	196	196
query99	573	576	510	510
Total cold run time: 252087 ms
Total hot run time: 173340 ms

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.x dev/3.1.x dev/4.0.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants