Skip to content

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Jan 9, 2026

What problem does this PR solve?

  1. Add type checking in Field::get()
  2. Use DecimalV2Value as ColumnItemType of TYPE_DECIMALV2

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Gabriel39 Gabriel39 requested a review from zclllyybb as a code owner January 9, 2026 10:23
@Thearas
Copy link
Contributor

Thearas commented Jan 9, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31468 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d9dfbf126b011265469b2b3d43c923e675e6b22e, data reload: false

------ Round 1 ----------------------------------
q1	17635	4271	4087	4087
q2	2077	379	245	245
q3	10124	1285	714	714
q4	10220	907	315	315
q5	7725	2178	1839	1839
q6	225	176	143	143
q7	922	790	654	654
q8	9280	1380	1253	1253
q9	4985	4665	4542	4542
q10	6834	1813	1394	1394
q11	501	288	292	288
q12	715	758	599	599
q13	17832	3821	3092	3092
q14	284	290	266	266
q15	594	504	508	504
q16	684	678	635	635
q17	676	838	451	451
q18	6622	6491	6415	6415
q19	1116	970	595	595
q20	398	353	238	238
q21	2975	2415	2219	2219
q22	1034	983	980	980
Total cold run time: 103458 ms
Total hot run time: 31468 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4128	4066	4041	4041
q2	330	383	315	315
q3	2076	2607	2261	2261
q4	1378	1763	1305	1305
q5	4078	3928	4075	3928
q6	212	175	131	131
q7	1892	1864	1697	1697
q8	2863	2467	2474	2467
q9	7273	7277	7034	7034
q10	2575	2748	2307	2307
q11	546	480	468	468
q12	697	789	686	686
q13	3651	4085	3357	3357
q14	400	320	275	275
q15	536	495	497	495
q16	649	687	647	647
q17	1363	1368	1425	1368
q18	7938	8178	7740	7740
q19	952	871	855	855
q20	1979	2044	1965	1965
q21	4827	4567	4053	4053
q22	1071	1010	981	981
Total cold run time: 51414 ms
Total hot run time: 48376 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172215 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d9dfbf126b011265469b2b3d43c923e675e6b22e, data reload: false

query5	4408	589	442	442
query6	335	231	242	231
query7	4225	454	250	250
query8	344	261	241	241
query9	8771	2724	2673	2673
query10	494	398	311	311
query11	15288	15162	14848	14848
query12	177	129	115	115
query13	1270	473	370	370
query14	6030	3025	2758	2758
query14_1	2669	2640	2635	2635
query15	212	202	175	175
query16	1002	481	455	455
query17	1117	701	595	595
query18	2443	446	333	333
query19	231	226	200	200
query20	131	117	118	117
query21	221	141	118	118
query22	3775	4092	3977	3977
query23	15885	15593	15381	15381
query23_1	15576	15496	15393	15393
query24	7349	1547	1177	1177
query24_1	1170	1157	1186	1157
query25	578	487	426	426
query26	1255	267	160	160
query27	2755	441	263	263
query28	4574	2158	2145	2145
query29	795	551	485	485
query30	311	232	210	210
query31	800	624	562	562
query32	78	65	62	62
query33	526	329	281	281
query34	879	863	514	514
query35	734	784	702	702
query36	898	872	823	823
query37	136	90	74	74
query38	2737	2700	2659	2659
query39	793	747	741	741
query39_1	709	717	711	711
query40	212	129	114	114
query41	67	62	65	62
query42	105	105	103	103
query43	455	429	423	423
query44	1294	717	719	717
query45	192	187	179	179
query46	817	937	553	553
query47	1406	1546	1356	1356
query48	292	310	227	227
query49	609	416	337	337
query50	598	276	234	234
query51	3837	3744	3790	3744
query52	104	106	95	95
query53	276	326	273	273
query54	280	265	240	240
query55	75	72	67	67
query56	281	286	278	278
query57	984	1026	950	950
query58	272	254	243	243
query59	2026	2116	2173	2116
query60	315	312	295	295
query61	160	161	154	154
query62	379	344	330	330
query63	294	259	269	259
query64	4946	1282	982	982
query65	3837	3791	3687	3687
query66	1450	430	303	303
query67	15385	14526	14657	14526
query68	5594	982	691	691
query69	506	337	300	300
query70	1074	963	831	831
query71	340	296	282	282
query72	6022	3334	3392	3334
query73	775	735	293	293
query74	8805	8784	8760	8760
query75	2841	2793	2449	2449
query76	3344	1060	623	623
query77	526	350	283	283
query78	9822	9785	9248	9248
query79	1599	885	560	560
query80	1544	543	466	466
query81	551	268	234	234
query82	419	139	107	107
query83	366	253	243	243
query84	251	113	96	96
query85	912	509	449	449
query86	394	298	291	291
query87	2886	2878	2791	2791
query88	2997	2059	2050	2050
query89	389	346	320	320
query90	1955	149	150	149
query91	177	162	141	141
query92	70	67	62	62
query93	1055	912	522	522
query94	641	313	287	287
query95	578	327	344	327
query96	558	450	195	195
query97	2370	2406	2296	2296
query98	222	195	197	195
query99	613	600	526	526
Total cold run time: 252119 ms
Total hot run time: 172215 ms

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31583 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 64021d47a6efcdd34c6f888c286fb300995ad13f, data reload: false

------ Round 1 ----------------------------------
q1	17614	4197	4063	4063
q2	2038	359	240	240
q3	10160	1288	724	724
q4	10210	813	313	313
q5	7519	2017	1902	1902
q6	190	175	146	146
q7	930	786	662	662
q8	9296	1366	1229	1229
q9	4998	4630	4539	4539
q10	6822	1807	1421	1421
q11	538	292	289	289
q12	718	764	574	574
q13	17807	3859	3067	3067
q14	300	300	272	272
q15	595	516	518	516
q16	686	697	630	630
q17	677	806	489	489
q18	6700	6471	6450	6450
q19	1099	974	643	643
q20	407	368	241	241
q21	2962	2486	2197	2197
q22	1039	1011	976	976
Total cold run time: 103305 ms
Total hot run time: 31583 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4172	4091	4050	4050
q2	329	408	312	312
q3	2094	2556	2252	2252
q4	1358	1753	1316	1316
q5	4069	3997	4073	3997
q6	217	171	128	128
q7	1852	1849	1704	1704
q8	2860	2558	2532	2532
q9	7304	7262	7055	7055
q10	2525	2667	2326	2326
q11	590	506	470	470
q12	711	765	651	651
q13	3576	4066	3298	3298
q14	305	316	412	316
q15	565	504	608	504
q16	756	669	624	624
q17	1164	1405	1449	1405
q18	8241	7999	7632	7632
q19	866	855	872	855
q20	2028	2093	1930	1930
q21	4745	4500	4604	4500
q22	1106	1062	1053	1053
Total cold run time: 51433 ms
Total hot run time: 48910 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173143 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 64021d47a6efcdd34c6f888c286fb300995ad13f, data reload: false

query5	4460	650	501	501
query6	342	228	213	213
query7	4216	455	256	256
query8	340	246	233	233
query9	8720	2869	2891	2869
query10	506	376	316	316
query11	15452	15234	14937	14937
query12	173	114	120	114
query13	1252	467	353	353
query14	5546	2958	2738	2738
query14_1	2648	2629	2637	2629
query15	203	192	174	174
query16	1002	491	486	486
query17	901	648	547	547
query18	2415	424	319	319
query19	225	219	186	186
query20	123	119	115	115
query21	212	138	115	115
query22	3991	4066	3920	3920
query23	15956	15659	15234	15234
query23_1	15525	15360	15463	15360
query24	7127	1523	1175	1175
query24_1	1177	1162	1197	1162
query25	526	464	427	427
query26	1251	271	152	152
query27	2768	438	270	270
query28	4637	2177	2155	2155
query29	777	548	454	454
query30	311	256	219	219
query31	779	628	569	569
query32	83	77	75	75
query33	532	364	312	312
query34	905	866	524	524
query35	756	781	678	678
query36	926	955	873	873
query37	132	105	88	88
query38	2669	2702	2651	2651
query39	780	765	729	729
query39_1	725	733	727	727
query40	225	140	123	123
query41	74	69	68	68
query42	108	110	107	107
query43	441	480	415	415
query44	1338	754	743	743
query45	187	191	183	183
query46	818	944	575	575
query47	1440	1399	1324	1324
query48	301	313	238	238
query49	634	444	349	349
query50	635	282	213	213
query51	3776	3825	3772	3772
query52	108	112	103	103
query53	290	326	275	275
query54	305	285	290	285
query55	84	85	79	79
query56	320	325	331	325
query57	1008	991	883	883
query58	293	275	265	265
query59	2043	2069	1993	1993
query60	344	335	309	309
query61	163	152	147	147
query62	391	377	319	319
query63	307	263	265	263
query64	4938	1273	971	971
query65	3801	3768	3735	3735
query66	1455	417	319	319
query67	15246	15026	15051	15026
query68	3753	1039	695	695
query69	509	348	314	314
query70	1070	948	888	888
query71	346	305	291	291
query72	6269	3619	3445	3445
query73	780	737	308	308
query74	8893	8761	8624	8624
query75	2768	2795	2425	2425
query76	3349	1056	665	665
query77	528	393	298	298
query78	9652	9963	9244	9244
query79	939	878	557	557
query80	628	576	475	475
query81	510	265	234	234
query82	301	148	112	112
query83	273	259	242	242
query84	299	113	98	98
query85	889	526	469	469
query86	337	325	290	290
query87	2801	2896	2763	2763
query88	2907	2136	2110	2110
query89	384	344	331	331
query90	2022	166	166	166
query91	172	162	142	142
query92	80	70	67	67
query93	1023	881	525	525
query94	593	330	306	306
query95	599	333	379	333
query96	546	476	199	199
query97	2313	2365	2270	2270
query98	209	206	200	200
query99	652	571	554	554
Total cold run time: 247802 ms
Total hot run time: 173143 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants