Skip to content

branch-4.0: [fix](cloud)Fix create dynamic table race with insert overwrite #59489 #59884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
deardeng wants to merge 2 commits into
base: branch-4.0
Choose a base branch
from
Open

branch-4.0: [fix](cloud)Fix create dynamic table race with insert overwrite #59489 #59884

deardeng wants to merge 2 commits into from
+189 −49

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Jan 14, 2026

cherry pick from #59489

@deardeng deardeng requested a review from yiguolei as a code owner January 14, 2026 11:21
@deardeng
Copy link
Contributor Author

deardeng commented Jan 14, 2026

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 14, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

deardeng commented Jan 14, 2026

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 14, 2026

FE UT Coverage Report

Increment line coverage 28.57% (16/56) 🎉
Increment coverage report
Complete coverage report

@yiguolei yiguolei closed this Jan 16, 2026
@yiguolei yiguolei reopened this Jan 16, 2026
@deardeng @yiguolei
[fix](cloud)Fix create dynamic table race with insert overwrite (a…
c3af819 
…pache#59489)

1. Thread 1 executed a DROP TABLE operation, followed by a CREATE TABLE
operation, initializing a dynamic partition (Partition A) in memory.
2. Due to an optimization in the cloud, batch partition edit logs were
attempted; however, the edit log for Partition A was not yet
synchronized to the followers.
3. Thread 2 began an INSERT INTO ... OVERWRITE PARTITION (*) operation,
identifying Partition A in memory and writing a replace partition edit
log.
4. In follower, the replay thread attempted to replay the replace
partition edit log but found a dependency on Partition A, which was
absent from memory, resulting in an exception and subsequent
termination.

Fix
```
2025-12-30 16:10:42,774 ERROR (replayer|123) [EditLog.loadJournal():1445] replay Operation Type 210, log id: 1910
java.lang.NullPointerException
        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:906)
        at org.apache.doris.catalog.OlapTable.checkPartition(OlapTable.java:2835)
        at org.apache.doris.catalog.OlapTable.replaceTempPartitions(OlapTable.java:2799)
        at org.apache.doris.catalog.Env.replayReplaceTempPartition(Env.java:6750)
        at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:986)
        at org.apache.doris.catalog.Env.replayJournal(Env.java:3100)
        at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2862)
        at org.apache.doris.common.util.Daemon.run(Daemon.java:119)
2025-12-30 16:10:42,775 INFO (Thread-0|32) [DorisFE.lambda$start$0():159] Received shutdown signal, starting graceful shutdown...
2025-12-30 16:10:42,776 INFO (Thread-0|32) [DorisFE.gracefulShutdown():639] graceful shutdown finished
```

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

None

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@deardeng @yiguolei
fix
247777c
@yiguolei yiguolei force-pushed the pick_59489_to_doris_branch-4.0 branch from f7156ef to 247777c Compare January 16, 2026 12:28
@yiguolei
Copy link
Contributor

yiguolei commented Jan 16, 2026

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 16, 2026

FE UT Coverage Report

Increment line coverage 28.57% (16/56) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei Awaiting requested review from yiguolei yiguolei is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deardeng @hello-stephen @yiguolei