Draft
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
englefly
force-pushed
the
eager-agg-0209
branch
2 times, most recently
from
f4f5719 to
ce1f61c
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 29681 ms |
TPC-DS: Total hot run time: 160452 ms |
ClickBench: Total hot run time: 28.35 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
ds14 增加了agg push，执行时间 4.7 -> 4.8 h13 增加了 agg push，应该让p6 恢复到 p4 的成绩，提高一些 当任一 group key的ndv 接近 行数（0.9 倍）时，不下推agg DORIS-24367 case-when 不能下推join 补null的一侧 pick unnest-subquery-cte ut-tmp adjust rt update-shape fix eager_agg.groovy, runtime_filter_mode=OFF; fmt 14/67 因为rebase后增加了 repeat 拆分, 形状变化 支持 min(if), max(if), 增加了context.isValid检查,避免无效下推 doris-24240: rewriteRoot 检查nullable失败则不做eagerAgg column pruning 不产生不合法 的setOp 24207-2: orExpansion union 字段没对齐 DORIS-24239 context.groupKeys 不能为空 DORIS-24206: fix EliminateGroupByKeyByUniform bug:没有替换alias的exprId DORIS-24205 1. union 的孩子不能部分改写 2. agg 输入字段和 group key 有交集,则不下推 LogicalProject 构造projectMap时不能有unbound DORIS-23842 没有aggFunc时 下推包含所有group key 的分支，而不是大分支. ds37/38/82/87 受到影响。select distinct A from T1 join T2 on ... group by A` aliasMap 使用HashMap，不用IdentityMap DORIS-24149 DORIS-24151 doris-24150 rt case 1. exprId 的等值判断, 2.update rt. DORIS-24150 update shape remove unused code 1. sum-if 不考虑穿过bigJoin， 2. 支持union q5 两个sum（0）错误去重了 sum-if 基本款 (还没有支持union), 43 有提升 simple sum-if no union 检查context的字段 是project的输出.拒绝 sum(A) 下推 proj(x, x+y as A) 且x 不是group key derive deep false throw exception for eager agg when FeDebug 1. remove finalGroupKeys, 2. project 下推后改写projects push agg on join group key only slotreference do not support avg/count mode=1 时 即使没有经过big join 也要 强制 下推 shape with/without pkfk based on tpc_preview
…ull侧的下推,这导致agg 推到了非补null侧
englefly
force-pushed
the
eager-agg-0209
branch
from
3ec5a56 to
d6f1edc
Compare
englefly
force-pushed
the
eager-agg-0209
branch
from
d6f1edc to
052aaec
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 27735 ms |
TPC-DS: Total hot run time: 153349 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)