Skip to content

[Fix](DDL) Make autoBucket flag modifiable and add testcases for ALTER TABLE BUCKETS#60651

Merged
zclllyybb merged 2 commits intoapache:masterfrom
zclllyybb:alter_bucket_test
Feb 25, 2026
Merged

[Fix](DDL) Make autoBucket flag modifiable and add testcases for ALTER TABLE BUCKETS#60651
zclllyybb merged 2 commits intoapache:masterfrom
zclllyybb:alter_bucket_test

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Feb 10, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 10, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Feb 10, 2026

run buildall

@zclllyybb zclllyybb changed the title [Test](DDL) Add testcases of alter table modify distribute [Fix](DDL) Make autoBucket flag modifiable and add testcases for ALTER TABLE BUCKETS Feb 11, 2026
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Feb 11, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Feb 11, 2026

TPC-H: Total hot run time: 30055 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 25aa0c18fb885b35c03c4db2bdff9c09515f4148, data reload: false

------ Round 1 ----------------------------------
q1	17630	4609	4286	4286
q2	2055	360	245	245
q3	10128	1283	718	718
q4	10194	775	307	307
q5	7472	2158	1931	1931
q6	189	176	147	147
q7	875	738	608	608
q8	9263	1376	1137	1137
q9	4742	4620	4581	4581
q10	6843	1949	1541	1541
q11	450	259	241	241
q12	340	378	219	219
q13	17790	4038	3251	3251
q14	238	235	215	215
q15	888	814	796	796
q16	676	673	624	624
q17	700	795	553	553
q18	6611	5753	5688	5688
q19	1232	1001	616	616
q20	498	500	382	382
q21	2516	1779	1730	1730
q22	331	282	239	239
Total cold run time: 101661 ms
Total hot run time: 30055 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4373	4331	4340	4331
q2	260	332	270	270
q3	2084	2668	2223	2223
q4	1466	1731	1269	1269
q5	4349	4221	4235	4221
q6	216	174	138	138
q7	1873	1751	1628	1628
q8	2426	2660	2507	2507
q9	7578	7403	7485	7403
q10	2902	3008	2560	2560
q11	512	448	420	420
q12	676	718	654	654
q13	4015	4359	3699	3699
q14	418	321	292	292
q15	905	811	817	811
q16	690	714	659	659
q17	1127	1297	1322	1297
q18	8730	8060	7777	7777
q19	875	862	863	862
q20	2155	2174	2110	2110
q21	4749	4660	4072	4072
q22	476	453	398	398
Total cold run time: 52855 ms
Total hot run time: 49601 ms

@doris-robot
Copy link

doris-robot commented Feb 11, 2026

TPC-DS: Total hot run time: 190376 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 25aa0c18fb885b35c03c4db2bdff9c09515f4148, data reload: false

query5	4499	611	479	479
query6	326	216	214	214
query7	4203	480	262	262
query8	336	262	249	249
query9	8743	2716	2701	2701
query10	519	356	344	344
query11	16657	16402	16148	16148
query12	175	120	116	116
query13	1255	453	368	368
query14	6085	3197	2932	2932
query14_1	2805	2783	2848	2783
query15	208	191	178	178
query16	968	467	460	460
query17	1093	696	595	595
query18	2433	445	342	342
query19	212	208	182	182
query20	135	125	123	123
query21	213	160	125	125
query22	4870	4928	4784	4784
query23	18970	18611	18409	18409
query23_1	18497	18458	18306	18306
query24	7176	1607	1202	1202
query24_1	1217	1201	1219	1201
query25	553	463	410	410
query26	1243	268	155	155
query27	2760	473	291	291
query28	4508	1875	1893	1875
query29	792	555	465	465
query30	324	255	219	219
query31	885	743	659	659
query32	88	79	80	79
query33	536	342	314	314
query34	919	914	565	565
query35	642	694	599	599
query36	1087	1099	1005	1005
query37	139	101	86	86
query38	2973	2917	2836	2836
query39	953	906	907	906
query39_1	884	887	873	873
query40	221	133	120	120
query41	68	66	61	61
query42	104	99	104	99
query43	451	463	406	406
query44	1303	719	721	719
query45	200	193	185	185
query46	872	979	605	605
query47	2091	2118	2090	2090
query48	327	314	232	232
query49	612	440	365	365
query50	663	280	214	214
query51	4240	4138	4073	4073
query52	105	105	94	94
query53	285	329	273	273
query54	291	261	266	261
query55	88	82	78	78
query56	301	318	310	310
query57	1422	1386	1257	1257
query58	282	267	265	265
query59	2076	2070	2124	2070
query60	349	326	324	324
query61	150	150	145	145
query62	577	543	512	512
query63	295	278	273	273
query64	4878	1272	934	934
query65	4515	4430	4504	4430
query66	1459	437	337	337
query67	16347	16178	16308	16178
query68	2459	1064	693	693
query69	412	325	281	281
query70	1080	941	921	921
query71	325	309	291	291
query72	2901	2733	2508	2508
query73	517	547	319	319
query74	9728	9618	9473	9473
query75	2799	2784	2447	2447
query76	2275	1057	646	646
query77	337	361	302	302
query78	11291	11360	10928	10928
query79	1066	918	593	593
query80	1280	564	489	489
query81	557	285	262	262
query82	1173	150	112	112
query83	344	260	241	241
query84	247	138	94	94
query85	906	474	416	416
query86	405	300	306	300
query87	3096	3060	2943	2943
query88	3564	2672	2638	2638
query89	394	337	323	323
query90	1933	178	171	171
query91	167	153	134	134
query92	77	71	73	71
query93	891	866	482	482
query94	632	319	309	309
query95	590	400	328	328
query96	652	504	227	227
query97	2473	2472	2435	2435
query98	229	210	207	207
query99	949	959	871	871
Total cold run time: 262555 ms
Total hot run time: 190376 ms

@doris-robot
Copy link

doris-robot commented Feb 11, 2026

ClickBench: Total hot run time: 28.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 25aa0c18fb885b35c03c4db2bdff9c09515f4148, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.08	0.09
query4	1.60	0.12	0.11
query5	0.26	0.25	0.25
query6	1.16	0.67	0.68
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.57	0.49	0.49
query10	0.55	0.55	0.55
query11	0.14	0.08	0.10
query12	0.14	0.10	0.10
query13	0.62	0.59	0.62
query14	1.06	1.05	1.06
query15	0.88	0.86	0.88
query16	0.39	0.40	0.38
query17	1.16	1.10	1.15
query18	0.23	0.21	0.21
query19	2.03	1.97	1.95
query20	0.02	0.02	0.01
query21	15.41	0.27	0.15
query22	5.18	0.06	0.05
query23	15.93	0.27	0.12
query24	2.32	0.62	0.31
query25	0.10	0.08	0.08
query26	0.14	0.13	0.14
query27	0.07	0.05	0.08
query28	4.01	1.15	0.96
query29	12.58	3.94	3.17
query30	0.29	0.14	0.11
query31	2.81	0.64	0.42
query32	3.24	0.58	0.49
query33	3.20	3.28	3.22
query34	16.21	5.36	4.71
query35	4.84	4.78	4.77
query36	0.65	0.49	0.49
query37	0.11	0.06	0.06
query38	0.07	0.05	0.05
query39	0.05	0.03	0.03
query40	0.21	0.16	0.16
query41	0.08	0.03	0.04
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 98.88 s
Total hot run time: 28.27 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 11, 2026

FE UT Coverage Report

Increment line coverage 25.00% (2/8) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 11, 2026

FE Regression Coverage Report

Increment line coverage 100.00% (8/8) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 12, 2026

FE Regression Coverage Report

Increment line coverage 100.00% (8/8) 🎉
Increment coverage report
Complete coverage report

HappenLee
HappenLee approved these changes Feb 21, 2026
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2026

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Feb 25, 2026
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zclllyybb zclllyybb merged commit 3e5257f into apache:master Feb 25, 2026
29 of 31 checks passed
@zclllyybb zclllyybb deleted the alter_bucket_test branch February 25, 2026 05:35
github-actions bot pushed a commit that referenced this pull request Feb 25, 2026
@zclllyybb
[Fix](DDL) Make autoBucket flag modifiable and add testcases for ALTE…
972a9bf 
…R TABLE BUCKETS (#60651)
@github-actions github-actions bot mentioned this pull request Feb 25, 2026
Merged
yiguolei pushed a commit that referenced this pull request Feb 28, 2026
@github-actions @zclllyybb
branch-4.0: [Fix](DDL) Make autoBucket flag modifiable and add testca…
16b4d60 
…ses for ALTER TABLE BUCKETS #60651 (#60825)

Cherry-picked from #60651

Co-authored-by: zclllyybb <zhaochangle@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@dataroaring dataroaring dataroaring approved these changes

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs CalvinKirs is a code owner

@morningman morningman Awaiting requested review from morningman morningman is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zclllyybb @Thearas @doris-robot @hello-stephen @HappenLee @dataroaring @yiguolei