[DRAFT] Update Calcite to 1.40 Take 2 #3024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgivre
added
code-cleanup
dependencies
calcite-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-XXXX: Update Calcite to 1.40
Description
This is a work in progress. I'm attempting to update Calcite to version 1.40. This is a very significant update to Drill. I had to modify some of the unit tests because Calcite change certain optimizations. For example, the default precision and scales are now different.
Documentation
(Please describe user-visible changes similar to what should appear in the Drill documentation.)
Testing
Ran existing unit tests.