fix flaky test in HttpEmitterTest#17904
Merged
cryptoe merged 1 commit intoapache:masterfrom Apr 12, 2025
Merged
Conversation
cryptoe
approved these changes
Apr 12, 2025
Contributor
|
Changes LGTM. Thanks for the PR . @cecemei |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This test can fail when the emitting process (emit/flush) took 0ms (could be the clock issue), the fix is to make sure
fillTimeMsis at least 1 .Tested this on my local with running until failure setting, it didn't fail until OOMed.
This PR has: