Skip to content

fix flaky test in HttpEmitterTest#17904

Merged
cryptoe merged 1 commit intoapache:masterfrom
cecemei:httpemitter
Apr 12, 2025
Merged

fix flaky test in HttpEmitterTest#17904
cryptoe merged 1 commit intoapache:masterfrom
cecemei:httpemitter

Conversation

@cecemei
Copy link
Contributor

@cecemei cecemei commented Apr 11, 2025

Description

This test can fail when the emitting process (emit/flush) took 0ms (could be the clock issue), the fix is to make sure fillTimeMs is at least 1 .

Tested this on my local with running until failure setting, it didn't fail until OOMed.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@cecemei cecemei marked this pull request as ready for review April 11, 2025 23:46
@cryptoe cryptoe merged commit 76ac5e4 into apache:master Apr 12, 2025
73 of 74 checks passed
@cryptoe
Copy link
Contributor

cryptoe commented Apr 12, 2025

Changes LGTM. Thanks for the PR . @cecemei

@capistrant capistrant added this to the 34.0.0 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants