Fix two issues where CursorHolders were not closed on failure of asCursor().#17915
Merged
cryptoe merged 2 commits intoapache:masterfrom Apr 15, 2025
Merged
Conversation
…rsor(). One in TopNQueryEngine (native) and one in ScanQueryFrameProcessor (MSQ). This is especially important because asCursor() itself can fail in ways that leave the CursorHolder with resources that must be closed.
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
cryptoe
approved these changes
Apr 15, 2025
kgyrtkirk
pushed a commit
to kgyrtkirk/druid
that referenced
this pull request
Apr 15, 2025
…rsor(). (apache#17915) * Fix two issues where CursorHolders were not closed on failure of asCursor(). One in TopNQueryEngine (native) and one in ScanQueryFrameProcessor (MSQ). This is especially important because asCursor() itself can fail in ways that leave the CursorHolder with resources that must be closed. * Fix style. (cherry picked from commit 0e81a19)
kgyrtkirk
added a commit
that referenced
this pull request
Apr 16, 2025
…rsor(). (#17915) (#17925) * Fix two issues where CursorHolders were not closed on failure of asCursor(). One in TopNQueryEngine (native) and one in ScanQueryFrameProcessor (MSQ). This is especially important because asCursor() itself can fail in ways that leave the CursorHolder with resources that must be closed. * Fix style. (cherry picked from commit 0e81a19) Co-authored-by: Gian Merlino <gianmerlino@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One in TopNQueryEngine (native) and one in ScanQueryFrameProcessor (MSQ).
This is especially important because asCursor() itself can fail in ways that leave the CursorHolder with resources that must be closed.