-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Update source-assembly configs to retain exe perms for scripts in source distribution #18353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update source-assembly configs to retain exe perms for scripts in source distribution #18353
Conversation
clintropolis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems good enough for making it so that can at least compile the source package, and certainly the most important set, though in 33.0.0 there are quite a few other files marked executable (some of these look like surely they were not intentional). Maybe some of the test running scripts would be nice to have, though also probably not required since I would assume the main reason to build from a source package is not to run the tests 🤷
$ find . -type f -perm +111
./integration-tests-ex/cases/cluster.sh
./integration-tests-ex/image/rebuild.sh
./integration-tests-ex/image/docker-build.sh
./integration-tests-ex/image/build-image.sh
./it.sh
./extensions-core/parquet-extensions/example/timestamps/date_test_data_job_string.json
./extensions-core/parquet-extensions/example/timestamps/date_test_data_job_date.json
./extensions-core/parquet-extensions/example/wiki/wiki.parquet
./extensions-core/parquet-extensions/example/wiki/wiki.json
./extensions-core/parquet-extensions/example/decimals/dec-in-i64.parquet
./extensions-core/parquet-extensions/example/decimals/dec-in-i32.parquet
./extensions-core/parquet-extensions/src/main/resources/META-INF/services/org.apache.druid.initialization.DruidModule
./extensions-core/parquet-extensions/src/main/java/org/apache/druid/data/input/parquet/DruidParquetAvroInputFormat.java
./extensions-core/parquet-extensions/src/main/java/org/apache/druid/data/input/parquet/avro/ParquetAvroHadoopInputRowParser.java
./extensions-core/parquet-extensions/src/main/java/org/apache/parquet/avro/DruidParquetAvroReadSupport.java
./extensions-core/orc-extensions/example/test_1_hadoop_job.json
./extensions-core/orc-extensions/src/main/resources/META-INF/services/org.apache.druid.initialization.DruidModule
./extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchToBase64StringPostAggregatorTest.java
./extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchAggregationTest.java
./extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchToMetricsSumEstimatePostAggregatorTest.java
./extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchToBase64StringPostAggregator.java
./extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchToMetricsSumEstimatePostAggregator.java
./extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchConstantPostAggregator.java
./extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchModule.java
./extensions-core/protobuf-extensions/src/main/resources/META-INF/services/org.apache.druid.initialization.DruidModule
./licenses/bin/@types-dom4.MIT
./processing/src/test/java/org/apache/druid/extendedset/intset/ImmutableConciseSetTest.java
./processing/src/main/java/org/apache/druid/query/aggregation/AggregatorUtil.java
./processing/src/main/java/org/apache/druid/extendedset/intset/ConciseSetUtils.java
./processing/src/main/java/org/apache/druid/extendedset/intset/ImmutableConciseSet.java
./processing/src/main/java/org/apache/druid/extendedset/intset/AbstractIntSet.java
./processing/src/main/java/org/apache/druid/extendedset/intset/IntSet.java
./processing/src/main/java/org/apache/druid/extendedset/intset/ConciseSet.java
./processing/src/main/java/org/apache/druid/extendedset/utilities/IntList.java
./website/script/notify-spellcheck-issues
./distribution/docker/druid.sh
./distribution/docker/deduplicate_jars.sh
./distribution/docker/peon.sh
./distribution/bin/generate-binary-notice.py
./distribution/bin/get-milestone-prs.py
./distribution/bin/build-textfile-readme.sh
./distribution/bin/find-missing-backports.py
./distribution/bin/jar-notice-lister.py
./distribution/bin/web-console-dep-lister.py
./distribution/bin/generate-binary-license.py
./distribution/bin/generate-license-dependency-reports.py
./distribution/bin/get-milestone-contributors.py
./distribution/bin/make-linkable-release-notes.py
./distribution/bin/check-licenses.py
./distribution/bin/tag-missing-milestones.py
./integration-tests/docker/run-mysql.sh
./integration-tests/docker/druid.sh
./integration-tests/docker/base-setup.sh
./integration-tests/docker/tls/set-docker-host-ip.sh
./integration-tests/docker/tls/generate-server-certs-and-keystores.sh
./integration-tests/docker/tls/generate-incorrect-hostname-client-cert.sh
./integration-tests/docker/tls/generate-valid-intermediate-client-cert.sh
./integration-tests/docker/tls/generate-invalid-intermediate-client-cert.sh
./integration-tests/docker/tls/generate-client-certs-and-keystores.sh
./integration-tests/docker/tls/generate-expired-client-cert.sh
./integration-tests/docker/tls/generate-good-client-cert.sh
./integration-tests/docker/tls/generate-to-be-revoked-client-cert.sh
./integration-tests/docker/tls/generate-untrusted-root-client-cert.sh
./integration-tests/docker/tls/generate-root-certs.sh
./integration-tests/stop_cluster.sh
./integration-tests/script/build_run_k8s_cluster.sh
./integration-tests/script/setup_k8s_cluster.sh
./integration-tests/script/setup_druid_operator_on_k8s.sh
./integration-tests/script/copy_resources_template.sh
./integration-tests/script/setup_druid_on_k8s.sh
./integration-tests/script/docker_build_containers.sh
./integration-tests/script/copy_hadoop_resources.sh
./integration-tests/script/stop_k8s_cluster.sh
./integration-tests/script/docker_run_cluster.sh
./integration-tests/build_run_cluster.sh
./integration-tests/gen-scripts/copy_resources.sh
./check_test_suite_test.py
./hooks/install-hooks.sh
./hooks/pre-commits/_pre-commit.sample
./hooks/uninstall-hooks.sh
./hooks/run-all-in-dir.py
./hooks/pre-pushes/_pre-push.sample
./hooks/pre-pushes/checkstyle-check
./hooks/pre-push
./hooks/pre-commit
./examples/bin/run-java
./examples/bin/start-cluster-master-with-zk-server
./examples/bin/start-druid
./examples/bin/start-single-server-medium
./examples/bin/greet
./examples/bin/run-druid
./examples/bin/post-index-task-main
./examples/bin/start-nano-quickstart
./examples/bin/start-cluster-query-server
./examples/bin/start-cluster-data-server
./examples/bin/jconsole.sh
./examples/bin/verify-default-ports
./examples/bin/dsql-main-py3
./examples/bin/run-zk
./examples/bin/start-micro-quickstart
./examples/bin/start-cluster-master-no-zk-server
./examples/bin/java-util
./examples/bin/post-index-task
./examples/bin/start-single-server-xlarge
./examples/bin/generate-example-metrics
./examples/bin/start-single-server-large
./examples/bin/verify-java
./examples/bin/service
./examples/bin/start-single-server-small
./examples/bin/supervise
./examples/bin/dsql
./examples/quickstart/protobuf/pb_publisher.py
./.github/scripts/analyze_dependencies_script.sh
./.github/scripts/license_checks_script.sh
./.github/scripts/create-jacoco-coverage-report.sh
./.github/scripts/setup_generate_license.sh
./.github/scripts/setup_test_profiling_env.sh
./.github/scripts/run-unit-tests.sh
./.github/scripts/test_balancing_calc
./web-console/script/create-sql-docs.mjs
./web-console/script/licenses
./web-console/script/clean
./web-console/script/druid
./web-console/script/mv
./web-console/script/mkcomp
./web-console/script/cp-to
./web-console/script/build
./web-console/src/dialogs/supervisor-table-action-dialog/__snapshots__/supervisor-table-action-dialog.spec.tsx.snap
./web-console/src/views/segments-view/__snapshots__/segments-view.spec.tsx.snap
./web-console/src/views/lookups-view/__snapshots__/lookups-view.spec.tsx.snap
./dev/upgrade-calcite-parser
./dev/chmod-heap-dumps.sh
./dev/quidem
./check_test_suite.py
./extensions-contrib/thrift-extensions/src/main/resources/META-INF/services/org.apache.druid.initialization.DruidModule
./extensions-contrib/druid-deltalake-extensions/src/test/resources/create_delta_table.py
./extensions-contrib/opentelemetry-emitter/src/main/resources/META-INF/services/org.apache.druid.initialization.DruidModule
./sql/src/test/resources/drill/window/datasources/allData.csv
./sql/src/test/resources/drill/window/queries/tpcds/query57.sql.fail
./sql/src/test/resources/drill/window/queries/tpcds/query51.drill_4811
./sql/src/test/resources/drill/window/queries/tpcds/query47.sql.fail
./sql/src/test/resources/drill/window/queries/tpcds/query98.drill_4525
./sql/src/test/resources/drill/window/queries/tpcds/tpcds_parquet_sf1.json
./sql/src/test/resources/drill/window/queries/tpcds/query89.sql.fail
./sql/src/test/resources/drill/window/queries/tpcds_variants/tpcds_parquet_sf1.json
Description
caused by: #18138
context: https://issues.apache.org/jira/browse/MASSEMBLY-941
impact: can't build from source in release artifacts (note that 33 was good, and this will be ported into 34 so no actual GA release will be impacted)
Fix
examples/binweb-console/scriptanddistribution/binRelease note
Key changed/added classes in this PR
distribution/src/assembly/source-assembly.xmlThis PR has: