Skip to content

Ignore all exceptions when pushing task logs #18748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhishekrb19 merged 3 commits into from
Nov 21, 2025
Merged

Ignore all exceptions when pushing task logs #18748

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bceefdc
Ignore all exceptions when pushing task logs
aho135 Nov 17, 2025
a15ff10
Add unit test to ensure that task succeeds even if log upload fails
aho135 Nov 20, 2025
e0f072a
style fixes
aho135 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions indexing-service/src/main/java/org/apache/druid/indexing/overlord/ForkingTaskRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,15 +524,15 @@ int waitForTaskProcessToComplete(Task task, ProcessHolder processHolder, File lo
try {
taskLogPusher.pushTaskLog(task.getId(), logFile);
}
catch (IOException e) {
catch (Exception e) {
LOGGER.error("Task[%s] failed to push task logs to [%s]: Exception[%s]",
task.getId(), logFile.getName(), e.getMessage());
}
if (reportsFile.exists()) {
try {
taskLogPusher.pushTaskReports(task.getId(), reportsFile);
}
catch (IOException e) {
catch (Exception e) {
LOGGER.error("Task[%s] failed to push task reports to [%s]: Exception[%s]",
task.getId(), reportsFile.getName(), e.getMessage());
}
Expand Down
Loading