Don't kill tasks while a supervisor is stopping. #18767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a supervisor was stopped while discovering tasks or updating their status, it could end up trying to kill those tasks because the callbacks on the requests to those tasks could fail as a result of the stopping. There should be no reason for an actively-stopping supervisor to kill a task, so this patch causes the shutdown functions to be no-ops while a supervisor is stopping.
This patch also ensures that when a supervisor transitions into the STOPPING state, that state takes priority over any other state.