Web console: refactor table filters, show inactive MSQ worker count #18768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
TableFiltersutility class to replace the direct usage of react-table'sFilterinterface throughout the web console, improving type safety and encapsulation.It also adds refresh buttons to JSON/stages viewers and implements inactive worker tracking for MSQ execution stages.
Key changes:
Filter[]with newTableFiltersclass that provides better encapsulation and helper methods. Simplified navigation logic throughout the console by consolidating filter-based navigation into a single goToView() functionShowJsonandShowJsonOrStagescomponents for easier data reloadinggetInactiveWorkerCount()method to calculate workers with zero input across all channels