-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix segment metadata query inconsistency bug with HLLSketch columns #18879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0a5bebf to
fa82391
Compare
fa82391 to
7ae979b
Compare
abhishekrb19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, looks good to me. I had a question about whether this also applies more generally in cases where we have different aggregators for the build vs output types (not just HLLSketch columns).
processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndex.java
Show resolved
Hide resolved
.../apache/druid/query/aggregation/datasketches/hll/HllSketchBuildSegmentMetadataQueryTest.java
Outdated
Show resolved
Hide resolved
.../apache/druid/query/aggregation/datasketches/hll/HllSketchBuildSegmentMetadataQueryTest.java
Outdated
Show resolved
Hide resolved
.../apache/druid/query/aggregation/datasketches/hll/HllSketchBuildSegmentMetadataQueryTest.java
Outdated
Show resolved
Hide resolved
.../apache/druid/query/aggregation/datasketches/hll/HllSketchBuildSegmentMetadataQueryTest.java
Outdated
Show resolved
Hide resolved
abhishekrb19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you also add a note to the release notes mentioning that this fix applies to other sketch aggregators as well?
...org/apache/druid/query/aggregation/datasketches/BaseSketchBuildSegmentMetadataQueryTest.java
Show resolved
Hide resolved
63e3737 to
9653a8a
Compare
Fixes #14315.
Description
As outlined in #14315, segment metadata queries issued against complex columns served by realtime data nodes (
IncrementalIndex) can potentially clash with type names of the same column (inQueryableIndex) served by historical nodes. I thought the best way to solve this was ensuring that the column type used is consistent across both data serving nodes (e.g. realtime and historical), rather than attempting to do some case-by-case coverage. Keeping as draft until I can confirm this doesn't break any other codepaths.Release note
Fix segment metadata query type inconsistency bug when querying between realtime and historical sketch columns.
This PR has: