Skip to content

Conversation

@jtuglu1
Copy link
Contributor

@jtuglu1 jtuglu1 commented Dec 31, 2025

Fixes #14315.

Description

As outlined in #14315, segment metadata queries issued against complex columns served by realtime data nodes (IncrementalIndex) can potentially clash with type names of the same column (in QueryableIndex) served by historical nodes. I thought the best way to solve this was ensuring that the column type used is consistent across both data serving nodes (e.g. realtime and historical), rather than attempting to do some case-by-case coverage. Keeping as draft until I can confirm this doesn't break any other codepaths.

Release note

Fix segment metadata query type inconsistency bug when querying between realtime and historical sketch columns.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jtuglu1 jtuglu1 force-pushed the fix-hll-sketch-build-issue branch 2 times, most recently from 0a5bebf to fa82391 Compare December 31, 2025 20:40
@jtuglu1 jtuglu1 force-pushed the fix-hll-sketch-build-issue branch from fa82391 to 7ae979b Compare December 31, 2025 21:57
@jtuglu1 jtuglu1 marked this pull request as ready for review December 31, 2025 21:58
@jtuglu1 jtuglu1 requested a review from abhishekrb19 December 31, 2025 22:11
Copy link
Contributor

@abhishekrb19 abhishekrb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, looks good to me. I had a question about whether this also applies more generally in cases where we have different aggregators for the build vs output types (not just HLLSketch columns).

Copy link
Contributor

@abhishekrb19 abhishekrb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also add a note to the release notes mentioning that this fix applies to other sketch aggregators as well?

@jtuglu1 jtuglu1 force-pushed the fix-hll-sketch-build-issue branch from 63e3737 to 9653a8a Compare January 5, 2026 23:09
@jtuglu1 jtuglu1 merged commit 7831f56 into apache:master Jan 5, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HLLSketchBuilder causes segment metadata queries to produce an error during realtime ingestion

2 participants