Skip to content

Add tier and priority dimension to segment/max bytes metric #18890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtuglu1 merged 1 commit into from
Jan 7, 2026
+10 −3
Merged

Add tier and priority dimension to segment/max bytes metric #18890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/operations/metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ These metrics are emitted by the Druid Coordinator in every run of the correspon

|Metric|Description|Dimensions|Normal value|
|------|-----------|----------|------------|
|`segment/max`|Maximum byte limit available for segments.| |Varies.|
|`segment/max`|Maximum byte limit available for segments.|`tier`, `priority`|Varies.|
|`segment/used`|Bytes used for served segments.|`dataSource`, `tier`, `priority`|< max|
|`segment/usedPercent`|Percentage of space used by served segments.|`dataSource`, `tier`, `priority`|< 100%|
|`segment/count`|Number of served segments.|`dataSource`, `tier`, `priority`|Varies|
Expand Down
7 changes: 6 additions & 1 deletion server/src/main/java/org/apache/druid/server/metrics/HistoricalMetricsMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,12 @@ public HistoricalMetricsMonitor(
@Override
public boolean doMonitor(ServiceEmitter emitter)
{
emitter.emit(new ServiceMetricEvent.Builder().setMetric("segment/max", serverConfig.getMaxSize()));
emitter.emit(
new ServiceMetricEvent.Builder()
.setDimension("tier", serverConfig.getTier())
.setDimension("priority", String.valueOf(serverConfig.getPriority()))
.setMetric("segment/max", serverConfig.getMaxSize())
);

final Object2LongOpenHashMap<String> pendingDeleteSizes = new Object2LongOpenHashMap<>();

Expand Down
4 changes: 3 additions & 1 deletion server/src/test/java/org/apache/druid/server/metrics/HistoricalMetricsMonitorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ public void testSimple()
final int priority = 111;
final String tier = "tier";

EasyMock.expect(druidServerConfig.getTier()).andReturn(tier).once();
EasyMock.expect(druidServerConfig.getPriority()).andReturn(priority).once();
EasyMock.expect(druidServerConfig.getMaxSize()).andReturn(maxSize).once();
EasyMock.expect(segmentLoadDropMgr.getSegmentsToDelete()).andReturn(ImmutableList.of(dataSegment)).once();
EasyMock.expect(druidServerConfig.getTier()).andReturn(tier).once();
Expand All @@ -92,7 +94,7 @@ public void testSimple()
monitor.doMonitor(serviceEmitter);
EasyMock.verify(druidServerConfig, segmentManager, segmentLoadDropMgr);

serviceEmitter.verifyValue("segment/max", maxSize);
serviceEmitter.verifyValue("segment/max", Map.of("tier", tier, "priority", String.valueOf(priority)), maxSize);
serviceEmitter.verifyValue(
"segment/pendingDelete",
Map.of("tier", tier, "dataSource", dataSource, "priority", String.valueOf(priority)),
Expand Down
Loading