always use StorageMonitor, also make StorageMonitor work for MSQ tasks#19048
Open
clintropolis wants to merge 3 commits intoapache:masterfrom
Open
always use StorageMonitor, also make StorageMonitor work for MSQ tasks#19048clintropolis wants to merge 3 commits intoapache:masterfrom
clintropolis wants to merge 3 commits intoapache:masterfrom
Conversation
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
capistrant
reviewed
Feb 26, 2026
Contributor
capistrant
left a comment
capistrant
left a comment
There was a problem hiding this comment.
code looks good. should we add docs though? especially now that the monitor is always on, I think it makes sense to get the metrics into the metrics table. Perhaps not blocking, I can flip to approve if you'd like to do it as a follow up
Member
Author
|
i think i'd rather do as a follow-up since none of the vsf stuff is documented yet and just get this as part of that. I think its mature enough to start documenting in the next release |
capistrant
approved these changes
Feb 27, 2026
Contributor
capistrant
left a comment
capistrant
left a comment
There was a problem hiding this comment.
I'm on board with a broader follow up for all vsf related docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
StorageMonitor, added in #18742, be always on. The low overhead seems worth the utility. Also added support for MSQ tasks to work correctly with this monitor, emitting extrataskIdandgroupIddimensions.