Refactor: Ensure that CompactionCandidate.currentStatus is non-null#19058
Open
kfaraz wants to merge 5 commits intoapache:masterfrom
Open
Refactor: Ensure that CompactionCandidate.currentStatus is non-null#19058kfaraz wants to merge 5 commits intoapache:masterfrom
kfaraz wants to merge 5 commits intoapache:masterfrom
Conversation
cecemei
approved these changes
Feb 26, 2026
Contributor
cecemei
left a comment
cecemei
left a comment
There was a problem hiding this comment.
Looks more clear with a non-null compaction status, left a few nits.
| { | ||
| final Set<Interval> segmentIntervals = | ||
| segments.stream().map(DataSegment::getInterval).collect(Collectors.toSet()); | ||
| final Interval umbrellaInterval = JodaUtils.umbrellaInterval(segmentIntervals); |
Contributor
There was a problem hiding this comment.
wondering if umbrellaInterval would be different from compactionInterval? seems like DataSourceCompactibleSegmentIterator.populateQueue would create DataSegment with updated interval and shard spec, if config.getSegmentGranularity is set.
| @@ -68,7 +86,7 @@ public static CompactionCandidate from( | |||
| umbrellaInterval, | |||
| compactionInterval, | |||
| segmentIntervals.size(), | |||
Contributor
There was a problem hiding this comment.
nit: could use CompactionStatistics to wrap numIntervals, totalBytes and numSegments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inspired by #18968 , this PR tries to ensure that the
currentStatusinside aCompactionCandidateis always non-null,with a relatively smaller changeset.
This PR has: